[MC-113897] Wooden planks paths for villages are used for lava as well

The bug

Wooden planks paths in villages are not only used for water but for all liquids. This means they are placed in lava as well.

How to reproduce

Seed: -7290508753372275080
Coordinates: /tp @s 65.73 75.00 -197.79 125.40 39.75

Code analysis

Based on 1.11.2 decompiled using MCP 9.35 rc1

The method net.minecraft.world.gen.structure.StructureVillagePieces.Path.addComponentParts(World, Random, StructureBoundingBox) only tests if the block is a liquid and then places wooden planks.

Attachments

Wooden planks village path in lava (17w06a).png

Comments 4

[Mod] bemoty 2017-08-17T22:18:02Z

Can confirm for MC 1.12.1.

migrated 2018-06-02T17:00:36Z

Affects 18w22c

pokechu22 2019-04-07T18:21:38Z

(appears to actually be fixed earlier than 19w14b; I'm currently looking. It's easy to test with a superflat world with a layer of lava, though (thanks oval))

pokechu22 2019-04-07T19:51:26Z

It's super inconvenient to test (due to MC-140238 and MC-124934) but I do believe this was fixed in 18w48a for plains villages, and later versions (each when it got its own type of new village). I did at least see no planks generating over the lava in 18w48a with the given seed, but if I forced (using buffet) a tiaga village it did generate a bridge. I'm going to resolve for 18w48a anyways.