[MC-114332] Emerald ore generation can load new chunks

The emerald ore generation does not offset by 8 X and 8 Z, so it will sometimes generate on a chunk boundary and load a new chunk during ore generation.
net.minecraft.world.biome.BiomeHills.EmeraldGenerator#generate (MCP names)

Other ores offset their generation by +8, +8 in order to generate properly. See net.minecraft.world.gen.feature.WorldGenMinable#generate (MCP names).

I made a reddit post to help mod makers follow this rule, and while looking into it I found that vanilla emerald ore has this issue.

Linked issues

relates to 2

MC-106524 Fossil generation causes chunks to be generated far away Resolved

MC-117810 Nether Lava Trap generation often loads new chunks Resolved

Comments 2

marcono1234 2017-06-23T10:54:58Z

Maybe the code has changed slightly since there is now no seperate emerald ore generator class in 1.12, instead it is done in net.minecraft.world.biome.BiomeHills.decorate(World, Random, BlockPos).

pokechu22 2018-07-18T01:19:26Z

This should be fixed as of 18w06a, but I'd like someone who knows world generation better to verify. Emerald ore now uses the same generation system as all other ores, instead of manually being created in decorate.