Sounds don't pause when game is paused on some UI screens

Please link this comment in the description

The following is based on a decompiled version of Minecraft 1.12 using MCP 9.40 pre-1.

When a game pausing GUI is opened, for instance the ingame menu, sounds are paused manually with the method call net.minecraft.client.Minecraft.mcSoundHandler.pauseSounds();. However, when the button "L" is pressed, the loop to open the advancements menu doesn't perform this specific method call. Therefore, a simple solution to this problem would be to add the method call to the loop.

Suggested fix

while (this.gameSettings.field_194146_ao.isPressed())
{
    if (this.isSingleplayer() && !this.theIntegratedServer.getPublic())
    {
           this.mcSoundHandler.pauseSounds();
    }
    this.displayGuiScreen(new GuiScreenAdvancements(this.player.connection.func_191982_f()));
}

Can confirm for MC 1.12.1.

Can confirm in 21w03a.

Can confirm in 21w05a.

Can confirm in 21w06a.

Can confirm in 21w07a.

Can confirm in 1.17.1.

Can confirm for MC 1.20.4.
I would like to add that I quit my singleplayer world while flying with an Elytra and the flying sound persisted until I reloaded my resources.

Can confirm in 1.20.5 rc-2 (elytra flying noises and music persist when opening the advancements window using the keybind in-game, for example).

Dunno why it’s marked as resolved when it’s still occurring in 1.21.7.