mojira.dev
MC-123450

Item frames play sounds when the item within them is read from NBT

The bug

Item frames play the sound entity.itemframe.add_item ("Item Frame fills") every time they read an item from NBT data. This happens when using commands like /data, but also when they are loaded from structures.

How to reproduce

  1. Summon an item frame with an item inside it by using the command provided below.

    /summon minecraft:item_frame ~ ~ ~ {Facing:1b,Rotation:[0.0f,-90.0f],Item:{id:"minecraft:diamond",Count:1b}}
  2. Have the item frame read NBT data by using the command provided below and listen closely as you do this.

    /data merge entity @e[type=item_frame,limit=1] {ArbitraryTag:1b}
  3. Take note as to whether or not item frames play sounds when the item within them is read from NBT.

Code analysis

Based on 1.12.2 decompiled using MCP 9.40

The method net.minecraft.entity.item.EntityItemFrame.setDisplayedItemWithUpdate(ItemStack, boolean) always plays the sound if there is an item in the item frame. Instead it should only do that when the second parameter (boolean) indicating whether or not the method was called by player interaction is false.

Linked issues

MC-296109 Item Frames & Glow Item Frames replay insert sound when reloading outside of spawn chunks Resolved MC-274041 If you die far away and return to the spawn point, if there is an item frame nearby, the subtitle in the bottom right corner will show the item frame: Fill Resolved MC-279823 Many Item Frames make deafening sound when loaded Resolved MC-263534 item frame makes rotating noise when a command makes it invulnerable Resolved MC-234521 "Item Frams Fills" sound plays when loading an area with filled item frames Resolved

Attachments

Comments 18

Possibly related:

When entering a server running on 1.13, nearby item frames seem to play item frame fill or rotation sound. This occurs whether the item in the frame is rotated or not.

This also happens when the player loads the world with a filled item frame nearby.

Same with teleporting away and teleporting back. (Anything to do with loading the frame up) Also confirmed 20w10a

Can confirm in 20w51a.

Can confirm in 21w06a.

8 more comments

Can confirm in 1.19 and 22w24a.

Can confirm in 1.19.2.

Can confirm in 1.21 Release Candidate 1.

can confirm in 25w33a

marcono1234

(Unassigned)

Confirmed

Platform

Low

Commands, Sound

/data, glow_item_frame, item_frame, nbt

Minecraft 1.12.2, Minecraft 17w50a, Minecraft 1.13-pre1, Minecraft 1.13.1, 1.14.4, ..., 1.20.6, 1.21, 1.21 Release Candidate 1, 1.21.4, 1.21.8

Retrieved