mojira.dev
MC-124137

Varieties of /teleport create ambiguities for tab-completion and syntax highlighting

The different syntaxes of /teleport introduce ambiguities for tab completion and syntax highlighting.

  1. Is the first argument destination or targets? "/tp @p <tab>" doesn't give tab completions for the <destination> argument. "/tp @a" doesn't complain that the <destination> argument may only return one entity.

  2. Is the first argument a player name or part of a set of coordinates? Attempting to teleport the player 1234321 to 0 0 0: type "/teleport 1234321" and start typing in the coordinates, after the y-coordinate, "1234321 0 0" will be highlighted as one argument even though it isn't.

  3. Is the second argument a player name or part of a set of coordinates? When I want to teleport myself to 0 0 0, I type "/teleport @p". After the x coordinate, it highlights the 0 in "/teleport @p 0" as a valid argument.

This could be fixed by introducing keywords or even subcommands like it was done to avoid ambiguities in /execute, or like it was done in /data.

Related issues

Comments

Maxaxik

Affects 18w20c

migrated

I'm not sure if this relates to this problem, but I've noticed in the logs that the game seems to issue these warnings every time:

[09:25:39] [Client thread/ERROR]: Realms module missing
[09:25:43] [Client thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[09:25:43] [Client thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[09:25:43] [Client thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[09:25:43] [Client thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[09:25:43] [Client thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[09:25:43] [Client thread/INFO]: Loaded 0 recipes

 

This example is from the 1.13-pre2 version but I've noticed it in previous snapshots as well.

migrated

1.13-pre5, on server startup:

 

[23:56:57] [main/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:56:57] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:56:57] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[23:56:57] [main/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[23:56:57] [main/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]

migrated

Still present in 1.13 full release. Is there anything for the server operator to do to resolve it?

migrated

Still present in 18w31a. Very confusing to see these at startup. 

SolidBlock

Confirmed in 32a.

Panossa

Confirmed for 1.13.1. Just disabled the vanilla datapack, restarted MC, enabled the vanilla datapack and after every /reload (even after another restart) it spams those ambiguity messages in the log. (Maybe it did that earlier on, I just noticed that)

migrated

Very confusing error message. I thought it was nether portal related first, (i did have some desynced portals).

After some googling it seems like it's nothing to worry about and that it's a mojang bug.

migrated

Still in all 1.14 snapshots.

SolidBlock

confirmed in 1.14.2

migrated

I still have this strange messages in the server console, but I dont use any teleport commands.

This messages happen on server start even when no player is logged in.

And I dont use any functions of datapacks. So why I get these warnings on server start ?

 

[21:39:02 WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[21:39:02 WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[21:39:02 WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[21:39:02 WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[21:39:02 WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
tryashtar

Those warnings are the game identifying that /teleport is an ambiguous command, because of the ability to do things like /tp x y z and /tp player x y z. It runs checks on all command definitions on server start to determine this. There is nothing you can do, and nothing to worry about.

migrated

Still in 19w37a.

migrated

@tryashtar I know that this messages are for teleport commands.

But the point is, in my world I have no teleport commands.

I dont use Commandblocks, and I dont have any datapacks what are using teleport commands, so why still get this message??

 

It is very confusing to get a bunch of warnings on each serverstart without the chance to fix this.

migrated

Because the commands still exist and are loaded into the game as a valid command.

migrated

@FVbico I know that the commands still exists, I follow the changelogs on each update.

The real question is, what can I do to avoid these warnings when I start my server ?

migrated

Nothing, except for wait for mojang to do something about it.

SolidBlock

Yes. Sometimes a bug is coped with to slowly.

migrated

Confirmed for 1.16 Pre-release 2

pulpetti

In 1.16.1 and 20w29a.

migrated

Also /tp @s ~ ~ ~ <facing|rotation> can't be completed with tab(Intentional to "rotation")

Avoma

Can confirm in 21w03a.

migrated

Still exists in 1.16.5 and 1.17.0.

Mojang, please can we get a Priority bump to clean up the console/error log? "Nothing to worry about" noise makes it harder to see real errors, so it's not really harmless. And it's been more than 3 years...

migrated

Also in 1.17.1... This gets really annoying on the server logs for sure, I keep on thinking the server is crashing on boot. As well as this, the weird entity tag starting dd12be always makes me think that there is some entity corruption or something... This really needs fixing for sure

migrated

The simplest fix I can think of: make the target entity a mandatory argument (so no /tp <pos> and no /tp <destination>) then /tp <entity> 0 will have 0 as destination, and /tp <entity> 0 0 will complain about a missing coordinate.
I recon people use the shortcut frequently, and will complain about it being lost; but people also use the /gamemode shortcuts/numbers and they were removed too (and they didn't even cause issues like the autocompletion). It'll just take those people a bit of getting used to, and there's no issues anymore.

MMK21

Affects 1.18

MMK21

Affects 1.18.1

Avoma

Can confirm in 1.18.2.

migrated

(Unassigned)

Confirmed

Platform

Low

Commands

/teleport

Minecraft 18w02a, Minecraft 18w06a, Minecraft 18w20c, Minecraft 1.13-pre1, Minecraft 1.13, ..., 1.17.1, 1.18, 1.18.1, 1.18.2, 23w05a

Retrieved