[MC-124717] 'execute store' ignores value validation

The bug

/execute store ignores value validation, allowing you to set values which would be considered invalid when used in the respective command.

Partially relevant /r/Mojira discussion

Affected situations

bossbar max
bossbar value
read-only scoreboard objectives

How to reproduce

`bossbar max`

Create a bossbar
```
/bossbar add custom:test "test"
```
Try setting a negative maximum
```
/bossbar set custom:test max -1
```
→ ✔ It fails as expected

Create a scoreboard objective and set a negative score

/scoreboard objectives add test dummy
/scoreboard players set value test -1

Try storing the score as bossbar max

/execute store result bossbar custom:test max run scoreboard players get value test

Get the bossbar max
```
/bossbar get custom:test max
```
→ ❌ It shows -1

Read only scoreboard objectives

Create a read only scoreboard objective and have it displayed on the sidebar

/scoreboard objectives add health health
/scoreboard objectives setdisplay sidebar health

Take damage or heal to update the score (see MC-111729)
Try setting a value for the health objective
```
/scoreboard players set @s health -1
```
→ ✔ It fails as expected

Create a scoreboard objective and set a negative score

/scoreboard objectives add test dummy
/scoreboard players set value test -1

Try storing the score as value for the read-only objective
```
/execute store result score @s health run scoreboard players get value test
```
→ ❌ Your health score changed to -1

Linked issues

is duplicated by

MC-124789 Bossbar for health broken

MC-223112 Boss health bar malfunctioning

relates to

MC-123307 '/execute store' can modify player data inside item "tags" of their Inventory or EnderItems

Comments

migrated 2018-06-02T17:13:04Z

Confirm for 18w22c

I tried to do some tests directly with NBT tags with the following commands in minecraft:repeating_command_block:

/execute store result bossbar foo:bar value run data get entity @e[type=minecraft:pig,limit=1,sort=nearest] Health
/execute store result bossbar foo:bar max run data get entity @e[type=minecraft:pig,limit=1,sort=nearest] Attributes[0].Base

When you create bossbar before executing previous commands and after you execute commands, no problems, it works.

But when the targeted entity dies, it broken.

After that, I tried another test with only "set value" of bossbar and no problems even if the targeted entity die and after yo summon another entity.

I think the problem is when you set the max value in the same time you set the value of the bossbar.

the only way I found to solve this problem is to remove the bossbar and recreate it.

migrated 2018-06-03T11:08:36Z

New fact, it's only a visual bug, when you test with the "get" command, these are the expected values.
And when you quit the world et reopen it, the problem is solved.

migrated 2018-06-04T23:13:39Z

Confirm for 1.13-pre1
I found the best way to fix it, just set the visibility to false, and after reset to true, it works but not as expected by the game ...

migrated 2018-06-19T02:46:55Z

Confirm for 1.13-pre2

migrated 2018-09-24T22:42:09Z

Confirmed for 1.13.1.

Avoma 2021-01-29T13:50:44Z

Can confirm in 21w03a.

Avoma 2021-02-17T12:42:23Z

Can confirm in 21w06a.