mojira.dev
MC-131017

Flattening Data Uses Invalid States

a(288, "{Name:\'minecraft:oak_leaves\',Properties:{check_decay:\'false\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'true\',variant:\'oak\'}}"});
        a(289, "{Name:\'minecraft:spruce_leaves\',Properties:{check_decay:\'false\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'true\',variant:\'spruce\'}}"});
        a(290, "{Name:\'minecraft:birch_leaves\',Properties:{check_decay:\'false\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'true\',variant:\'birch\'}}"});
        a(291, "{Name:\'minecraft:jungle_leaves\',Properties:{check_decay:\'false\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'true\',variant:\'jungle\'}}"});
        a(292, "{Name:\'minecraft:oak_leaves\',Properties:{check_decay:\'false\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'false\',variant:\'oak\'}}"});
        a(293, "{Name:\'minecraft:spruce_leaves\',Properties:{check_decay:\'false\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'false\',variant:\'spruce\'}}"});
        a(294, "{Name:\'minecraft:birch_leaves\',Properties:{check_decay:\'false\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'false\',variant:\'birch\'}}"});
        a(295, "{Name:\'minecraft:jungle_leaves\',Properties:{check_decay:\'false\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'false\',decayable:\'false\',variant:\'jungle\'}}"});
        a(296, "{Name:\'minecraft:oak_leaves\',Properties:{check_decay:\'true\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'true\',variant:\'oak\'}}"});
        a(297, "{Name:\'minecraft:spruce_leaves\',Properties:{check_decay:\'true\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'true\',variant:\'spruce\'}}"});
        a(298, "{Name:\'minecraft:birch_leaves\',Properties:{check_decay:\'true\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'true\',variant:\'birch\'}}"});
        a(299, "{Name:\'minecraft:jungle_leaves\',Properties:{check_decay:\'true\',decayable:\'true\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'true\',variant:\'jungle\'}}"});
        a(300, "{Name:\'minecraft:oak_leaves\',Properties:{check_decay:\'true\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'false\',variant:\'oak\'}}"});
        a(301, "{Name:\'minecraft:spruce_leaves\',Properties:{check_decay:\'true\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'false\',variant:\'spruce\'}}"});
        a(302, "{Name:\'minecraft:birch_leaves\',Properties:{check_decay:\'true\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'false\',variant:\'birch\'}}"});
        a(303, "{Name:\'minecraft:jungle_leaves\',Properties:{check_decay:\'true\',decayable:\'false\'}}", new String[] { "{Name:\'minecraft:leaves\',Properties:{check_decay:\'true\',decayable:\'false\',variant:\'jungle\'}}"});

These states not exist anymore so converting 1.12 data to them is wrong.

Same applies for TNT, although that's different because the functionality has been removed entirely.

a(736, "{Name:\'minecraft:tnt\',Properties:{explode:\'false\'}}", new String[] { "{Name:\'minecraft:tnt\',Properties:{explode:\'false\'}}"});
        a(737, "{Name:\'minecraft:tnt\',Properties:{explode:\'true\'}}", new String[] { "{Name:\'minecraft:tnt\',Properties:{explode:\'true\'}}"});

.

Linked issues

Comments

pokechu22

Are you sure that this causes an issue? Wouldn't the states in question be later removed by the next upgrade path, that migrates leaves from that format to the new one?

The TNT one is valid, though (the state was directly removed in MC-122563 and doesn't need to exist anymore).

md_5

>Are you sure that this causes an issue? Wouldn't the states in question be later removed by the next upgrade path, that migrates leaves from that format to the new one?

Probably, the new upgrade code is not exactly easy to follow. I'll leave it open for the sake of the TNT path.

Jayceebee

@unknown TNT has been fixed, explode=true now changes to unstable=true, so I suppose this can be closed

wobst.michael

Is this still an issue in the most recent versions (currently that is 1.13.2, or the latest snapshot 19w12b) of Minecraft? If so, please update the affected versions and help us keeping this ticket updated from time to time. If you are the owner/reporter of this ticket, you can modify the affected version(s) yourself.

md_5

(Unassigned)

Unconfirmed

(Unassigned)

Minecraft 1.13-pre1

Retrieved