[MC-138886] Exception is not logged when reading options.txt entry fails

The bug

When an entry of the options.txt file could not be read only the warning "Skipping bad option" with option name (and value) is logged. In some cases this is not enough information, instead the thrown exception should be logged as well.

How to reproduce

Create a backup of your options.txt file
Edit the current options.txt:
- Add an entry without separator (:):
```
test
```
- Add an entry with invalid float value:
```
mouseSensitivity:invalid
```
Start Minecraft
Look at the log
❌ It only logged "Skipping bad option" with the option name, but did not log the exception (indicating why the option is malformed)

Code analysis

20w10a, Mojang names

See net.minecraft.client.Options.load() and look for "Skipping bad option" (there are two occurences).

Comments 6

akarys 2018-11-06T11:15:34Z

It’s not a bug...

violine1101 2020-03-23T15:54:45Z

The "Skipping bad option" warning doesn't seem to be present anymore.

marcono1234 2020-03-25T00:19:58Z

Reopened because this is still the case in 20w12a, however the previously mentioned reproduction steps do not cause this issue anymore.
(Code analysis has version 20w10a on purpose)

violine1101 2020-03-26T22:42:48Z

I checked in 20w12a, and it seemed like the game just silently reset the value to default value instead of throwing any kind of exception in the first place. So, this ticket is about such a warning not existing now?

marcono1234 2020-03-28T23:40:58Z

It only happens for some option types (e.g. does not happen for booleans). I have added reproduction steps now.
This report is still only about the exception not being logged.

marcono1234 2021-10-01T17:07:57Z

Resolving this as Cannot Reproduce because it appears in 21w05a option parsing was refactored and now the exception is logged.