mojira.dev
MC-147869

Narrator narrates key bindings with "button" suffixed

When changing the key bindings the narrator narrates the current binding as  narrator.controls.bound%s is bound to %s

The second parameter is replaced by  gui.narrate.button%s button  where that parameter is replaced by the actual key/button name.

This yields to narrations like

Jump is bound to space button

Attack is bound to left click button

This is already weird in English (a key is not a button!), but in other languages using a translation for  gui.narrate.button e.g. in German "Schaltfläche" this is even weirder.

 

Proposal: Don't replace the second parameter of narrator.controls.bound by gui.narrate.button, just use the actual key/button name there.

 

Comments 3

One thing you did not address is that "left click" is not called "left click", but "left button". So in reality it's even weider because the narrator actually says the word "button" twice, i.e. "Attack/Destroy is bound to left button button"!

Confirmed in 1.16-pre2.

At the very least it should be changed so that the entire "<action> is bound to <key>" string is used as the placeholder for "%s button", instead of just the key name. This is pretty annoying in languages such as Italian which use a different word order for "%s button" - the result is something like "<action> is bound to button <key>". The best fix would still be not using "%s button" at all for these buttons.

kumasasa

(Unassigned)

Confirmed

Accessibility

Minecraft 19w14b, Minecraft 1.14 Pre-Release 1, 1.16.5, 21w20a, 24w39a

Retrieved