Players and mobs do not die from great heights in shallow water

Fix this please, breaks all ma shit

this needs to be fixed and due to the serious damage to existing in game traps this should be upgraded to major or showstopper

@Mead Regardless of whether or not this is in the change log it is still a bug because it breaks things just like ladder changes and other game play changes there can be unintended side effects and it us the duty of the development team to weight the benefits and disadvantages of these changes and when issues arise from the changes THEY ARE BUGS and it is not yours or the mod teams place to close a topic that indicates problems caused by a mechanic change. please stop disregarding valid issues and shunting them to the forums as feature requests because it makes both the mod team and development team LOOK BAD as it seems like a TLDR we dont care statement

Confirmed in 1.4.5. Adjusted the title.

very annoying, also makes jumping off mountains too easy.

This is a particularly infuriating bug as it as broken several grinders and PVP traps on servers I play on. I believe it should be given a hight priority, as it is a regression and greatly impacts gameplay.

The current code (1.4.7) indeed resets fall distance to zero as soon as it detects even a single tick of wet feet.

I tried different tricks to make it reduce damage in a way that would both reduce/prevent damage in deep enough water, and allow deadly damage with high enough drop to shallow enough water, but the way the physics works in Minecraft (really awkwardly) for falling and in water, I couldn't figure out a way to do it without a bit larger changes.

And if I'd go for larger changes, I'd just redesign the physics to work more naturally, which would make the problem much easier to solve.

Solution was too simple, although I don't like it personally, it is too much of "kludge". But it works and does make sense.

Existing code has

Entity.handleWaterMovement()

...
if (this.worldObj.handleMaterialAcceleration(...) {
    ...
    this.fallDistance = 0;
    ...
}
...

Fix
Consider this piece of code as just a proof of concept; I think parts of it could be done in better ways. The test for water above might be unnecessary, but I did notice once during earlier tests that it seemed it slipped through the first layer of water without detection, so it is a sort of backup.

Entity.handleWaterMovement()

...
if (this.worldObj.handleMaterialAcceleration(...) {
    ...
    if (this.fallDistance > 3.0F) {
        int blockId;
        blockId = this.worldObj.getBlockId(MathHelper.floor_double(this.posX), MathHelper.floor_double(this.boundingBox.minY) - 1, MathHelper.floor_double(this.posZ));
        if (blockId == Block.waterStill.blockID || blockId == Block.waterMoving.blockID) {
            this.fallDistance = 0;
        } else {
            blockId = this.worldObj.getBlockId(MathHelper.floor_double(this.posX), MathHelper.floor_double(this.boundingBox.minY) + 1, MathHelper.floor_double(this.posZ));
            if (blockId == Block.waterStill.blockID || blockId == Block.waterMoving.blockID) {
                this.fallDistance = 0;
            } else {
                this.fallDistance = this.fallDistance - 1.0F;
            }
        }
    } else {
        this.fallDistance = 0;
    }
    ...
}
...

Basically, it checks whether there is more water below or above, and simply clips falling distance to zero in such case. For shallow water, it only reduces the falling distance a bit (in the above example, by only 1 for my easier testing, and, well, a little bit more realism). Also, if the falling distance is already low enough, it clips it to zero.

I tested by jumping from about 7, 16, and 25 blocks above the water surface, into flowing layer of water, and into two blocks of water (source on top, flowing down one block). As expected, death only occurred when coming down from 25 to shallow, and damage occurred from lower height to shallow. From very low heights or to deeper water prevented all damage.

Consider the "fix" above a solution, not necessarily a good one.

Affects 13w09b.

This is a bug? I thought it was a feature to make our lives easier! LOL XD

You really should make velocity dependent fall damage.
Pfaeff makes a proposition here :
http://www.minecraftforum.net/topic/193506-fall-damage-calculation-with-solution/
It would be realistic and water could really serve to the same thing, making our velocity lower, and get less damage (or none)

Yes, while trying to make those fixes of mine, I noticed that it would have been a lot easier if the fall damage was based on velocity. (Or more correctly, on the massive acceleration at the sudden stop, as that would handle even the realistic case of getting damage from falling into water from too great heights, though I can already hear the cries against that). However, making such changes seemed to propagate quite quickly to too many places for me to provide the fixes for here in comments, and such change also changes game mechanics, so it would be feature request, quickly blocked in here (and unfortunately never getting anywhere in the semi-official place for suggestions).

So, lets keep it at the small/easy fix-it-only level in here, and wait. Then wait a lot more.

Changing falling damage to be based on velocity would also fix issues where falling damage is applied inappropriately or accumulates over time, such as MC-881 and MC-14167.

having fall damage depend on velocity would also stop players from taking huge amounts of damage when fly mode is enabled in survival. Because frankly, having to swoop down to collect items off the ground while being extra careful not to touch it is just annoying.

Affect 13w22a

When this gets fixed, it needs to be publicized like crazy! Right now, people are accustomed to the water-fall safety this bug provides. If it isn't publicly known when it is fixed, so many people will die.

No worries, John. When it gets fixed you'll know it, because everyone who built a grinder before this bug started in 1.4 will be having a Joy Parade since their stuff works again.

@Chip Seraphine

I don't think many people who built a mob grinder that depends on this bug not existing before 1.4.3 wouldn't fix their mob grinder to accompany this bug after a year of this bug not getting fixed, unless they gave quit playing Minecraft.

Confirmed in 1.6.2

Actually, there is quite a bit of it-- the bug has been marked 'confirmed' and is a regression. Usually such bugs are fixed in short order, although this one seems to have remarkable staying power. I've seen a lot of grinder-owners build new (additional) ones, of course, especially with hoppers.

It would be good to see this fixed before too many players produce creations that depend on falling safely into thin water.

Could a Mod please update the afeccted versions to 1.6/1.6.1/1.6.2. Thank you.

o_O I'm pretty sure that because Mojang couldn't fix (or didn't wanna waste time on) the inconsistency in fall damage on water they officially said (Jeb or Dinnerbone via twitter?) that water will prevent fall damage no matter what the fall height.

This is another case of a feature being implemented then later removed without explanation.
It would be nice to see this fixed again by having fall damage be calculated by momentum, not distance.

@Philo Wintercoat
Actually, if the falling mechanics would get changed, the proper thing to base the damage on is the acceleration, not momentum. Acceleration is quite easy to calculate; all the values are already there in the code. This would automatically take care of collisions between two moving objects (whether they move the same or opposite directions), falling to slopes, falling to water, splatting into walls sideways, whether living entity is the one moving and stopping or something else moves into a non-moving living entity and makes it move, etc.

Hmm... coming to think of it, I'm not sure if the masses of things exist in the code, that would be needed for collisions between two moving/movable things. Without masses, only collisions between moving and fixed & hard things can be handled properly.

But, that all is a "feature request". This issue already has a bit crude example fix, and can be fixed (or at least improved) without getting into changing mechanics.

Confirmed!... also affect versions 1.6.4 and Pre-release 1.7. Can you update it in the report?. Thank! 🙂. I hate this bug v.v

This is works as intended.

By which you mean you've gotten used to the bug, and it would break your stuff if the behavior went back to the old way.

I'm OK with that. I've got some old grinders that have been shut down for ages, but I don't want to remodel them because I don't know when/if the behavior will revert. I'd love to see this fixed, but if we can't get it fixed then I'd like for Mojang to close it as a WONTFIX and we can move on with our lives.

This event is clearly a bug, with many votes against... also, if this is not a bug... it is not reopened 😉

Is this still a concern in the latest Minecraft version 14w03b? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Yes, this is absolutely still happening.

Cam someone from Mojang either say "Yes, we'll fix it" or "No, you are no longer supposed to take falling damage if you hit shallow water"? I've got users on my server (including myself!) who still ask about this regularly, since they don't want to trash and rebuild big mob grinders while there is an open bug.

I'm almost 100% sure this is intended, I remember reading this somewhere. Can't find it in any changelogs though.

using a quick drop with signs, you can survive 499 blocks with full health but die at 500 blocks.