mojira.dev
MC-16883

Villagers play the trade sound multiple times overlapping on shift-click

The bug

If you place a stack of emeralds in a one for one trade (for example), and shift click the result, the villager will make the trade sound 64 times in quick succession, all overlapping.

I would have expected a cool-down of at least the length of the sound (and only one on shift-click, as 64 in succession overlapping or not, would still be ridiculous).

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

Comments 14

Still a concern, updated

still exists in 14w28b and 1.7.10

4 more comments

I wrote a command for anyone who would like to test this bug to check if it still exists. Run the following command:

/summon villager ~ ~ ~ {Offers:{Recipes:[{maxUses:128,buy:{id:"minecraft:emerald",Count:1b},sell:{id:"minecraft:diamond",Count:1b}}]}}

This will summon a villager who sells one emerald for one diamond. You can easily grab a stack of emeralds and test the bug. I hope this helps!

Is 1.14 Pre Release 1 affected? Because it's not on the list despite Pre Release 2 being affected. 

It just hasn't been tested. I haven't had time to test every snapshot lately, because it's finals season. Is there some reason you'd expect pre-1 not to be affected? If so, I can try to find time to test it, but otherwise I'd assume it is.

You can also feel free to test it yourself, though it is a little less obvious now, as V&P villagers tend to do fewer trades in a row.

Still in 1.14 Release

I can confirm that this bug has been patched!

Cultist_O

migrated

Confirmed

(Unassigned)

shift-click, sound, trade, villager

Snapshot 13w22a, Minecraft 1.6.2, Minecraft 1.7.4, Minecraft 14w03b, Minecraft 1.7.10, ..., Minecraft 1.14 Pre-Release 5, Minecraft 1.14, Minecraft 1.14.1 Pre-Release 1, Minecraft 1.14.1 Pre-Release 2, Minecraft 1.14.1

Minecraft 1.14.2 Pre-Release 1

Retrieved