[MC-186109] You can use multiplayer commands on a singleplayer world

When playing on a singleplayer world, you can use multiplayer server comands like /ban and other.

Linked issues

clones

MC-121636 Server commands available in singleplayer with weird/bad effects

is duplicated by

MC-186176 Able to use server commands in single player worlds

Comments

MMK21 2020-05-29T14:10:11Z

Can confirm in ~~20w21a~~ 20w22a

Earthcomputer 2020-05-29T14:42:40Z

@Mish Rodic you mean 22a? I can't confirm in 21a, only 22a.

modmuss50 2020-05-29T15:18:12Z

This bug seems to have been added in 22a. When updating fabric it caused our command tests to fail.

The fix seems trivial (Talking in official mojang names):

In Minecraft.selectLevel, ServerResources.loadResources is called with true being passed as the 2nd argument, this should be false, as its being ran on the intergrated server. This boolean is only used when true to enable the dedicated server commands (such as Ban and Stop). I created a mixin [gist|https://gist.github.com/modmuss50/8a65868faa5d4a0ffe60649b16a06153] to change this and validated that it fixed the issue.

MMK21 2020-05-29T16:03:19Z

Ah, yes. 20w22a. 🤦