The bug
Similar to MC-191388 but a new issue (this is a not a duplicate or a "wasn't fixed correctly" - this is a new issue)
Jigsaw World Gen Features is triggering codec errors like the following:
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[\{name:"minecraft:no_op",config:{}}]
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{stat
e_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[\{name:"minecraft:no_op",config:{}}]
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{stat
e_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[\{name:"minecraft:no_op",config:{}}]
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:flower",config:{tries:64
,yspread:3,xspread:7,need_water:0b,zspread:7,blacklist:[L;],project:1b,block_placer:{type:"minecraft:simple_block_placer"},state_provider:{type:"minecraft:plain_flower_provider"},whitelist:[L;],can_replace:0b}}]
[19:34:04] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[\{name:"minecraft:no_op",config:{}}]Using Spigot/Paper mappings, the callstack of where this is triggered is
https://gist.github.com/aikar/56b0c2beff6d8c70e18893a72889eb76
Code triggering it is this:
this.b = new BlockPosition(nbttagcompound.getInt("PosX"), nbttagcompound.getInt("PosY"), nbttagcompound.getInt("PosZ"));
this.e = nbttagcompound.getInt("ground_level_delta");
DataResult dataresult = WorldGenFeatureDefinedStructurePoolStructure.e.parse(DynamicOpsNBT.a, nbttagcompound.getCompound("pool_element"));Unsure about data corruption, but can be spammy.
Reproduction steps
Create a world in 1.15.2 and teleport to a village; or use the attached world
Open the world in the latest version
❌ Multiple errors are logged
Root Cause
The Root Cause is that there are items in the FEATURE registry that are specifying "name" as their identifier instead of "type", and these are mixed into the same collection.
This code in Spigot mappings is the source point:
public class WorldGenFeatureConfigured<FC extends WorldGenFeatureConfiguration, F extends WorldGenerator<FC>> implements IDecoratable<WorldGenFeatureConfigured<?, ?>> {
public static final Codec<WorldGenFeatureConfigured<?, ?>> a = IRegistry.FEATURE.dispatch((worldgenfeatureconfigured) -> {
return worldgenfeatureconfigured.e;
}, WorldGenerator::a);
public static final Codec<Supplier<WorldGenFeatureConfigured<?, ?>>> b = RegistryFileCodec.a(IRegistry.au, WorldGenFeatureConfigured.a);
public static final Codec<List<Supplier<WorldGenFeatureConfigured<?, ?>>>> c = RegistryFileCodec.b(IRegistry.au, WorldGenFeatureConfigured.a);
public static final Logger LOGGER = LogManager.getLogger();
Changing this to .dispatch("name", (....
Fixes the errors for the ones listed in the ticket, however then breaks every thing using type.
The data sets need to be updated to consistently use type.
Linked issues
is duplicated by 1
Attachments
Comments
marcono1234
Could you please attach a world which is causing this issue (and mention steps for causing it)?
Or can you describe reproduction steps for creating a world which, when opened in the latest version, causes this issue?
Attached a screenshot from a user, appears this is still the same damage as MC-191388
To reproduce, creating a world in 1.15 and finding a village, and I'm not sure if partial generation applies or not, but if it does, stop moving soon as part of a village is seen, and then open that world in 1.16.2
I will try to attach some files I have reproducing this every time after work too, just need to try to filter it to just needed files first and get coords.
I have one report that it was related to partial generation, but in my own test world I get it at my "Home" location which is a village and i know it was fully generated.
Another suspect is if a village doesn't have a pillar outpost, and my village does not... (likely created in 1.12).
Hope this helps.
The issue occurs with fully generated villages too in my testing. The screenshot is due to partial generation, if you regenerate a village that was generated pre 1.16 in a 1.16 world it will look different.
World generated on 1.15.2, upgraded to 1.16.2/when upgraded to 1.16.2 that has the issue: https://drive.google.com/file/d/130h8UJWViF-YL_UKjszo1RJlsJdabzMc/view?usp=sharing
Seed: 1234
Coords: -415 70 114
marcono1234
Thanks to both of you. I have created a world with the seed and coordinates @unknown provided and was able to reproduce it. I have attached the world (before it was loaded in 1.16.2) as
[media].
I can say it more an grass some are different in 1.16, for villagers
I fix a village with worldedit and it was not same villager any more. It it a preloaded world (but i think no player has goo tho that villagers before).
It was similar issue when you upgrade from 1.14.4 to 1.15, but in that case it was hay some cause the issue (was not so big visual glitch).
So i guess, if mojange change the code how villager is generated, so can you get this error (but it should not infect already generated chunks).
Is good a mod get same error, i hope he notify mojang and they release a hot fix, so we not have to want on 1.17 or 1.16.3.
I've got a report now it even impacts a fresh 1.16.1 generated chunk too.... so impact is a bit higher as it covers everyone doing a point release, and people really dont want to regen worlds for a point release so fast.
Root issue appears that there are registries that are specifying "name" as their identifier instead of "type"
We tried updating the .dispatch() call for Configured World Gen Features to be name instead, and it solved THIS specific issues, but caused others that do actually use "type"...
so we have a mixed data set.
Mojang will have to correct the data points to be consistent as type.
We're going to bandaid it by checking if type doesnt exists, try name
i get a similar error, consistently every time i go through one particular portal towards the overworld
```[13:40:17] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:random_patch",config:{tries:10,yspread:3,xspread:7,need_water:0b,zspread:7,blacklist:[],project:0b,block_placer:{extra_size:2,min_size:1,type:"minecraft:column_placer"},state_
provider:{state:{Properties:{age:"0"},Name:"minecraft:cactus"},type:"minecraft:simple_state_provider"},whitelist:[],can_replace:0b}}]
[13:40:17] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[13:40:17] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:random_patch",config:{tries:10,yspread:3,xspread:7,need_water:0b,zspread:7,blacklist:[],project:0b,block_placer:{extra_size:2,min_size:1,type:"minecraft:column_placer"},state_
provider:{state:{Properties:{age:"0"},Name:"minecraft:cactus"},type:"minecraft:simple_state_provider"},whitelist:[],can_replace:0b}}]
[13:40:17] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[13:40:17] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[13:40:17] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[13:40:40] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:random_patch",config:{tries:10,yspread:3,xspread:7,need_water:0b,zspread:7,blacklist:[],project:0b,block_placer:{extra_size:2,min_size:1,type:"minecraft:column_placer"},state_
provider:{state:{Properties:{age:"0"},Name:"minecraft:cactus"},type:"minecraft:simple_state_provider"},whitelist:[],can_replace:0b}}]
[13:40:40] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[13:40:40] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:simple_state_provider"}}}]
[13:41:09] [Server Watchdog/FATAL]: A single server tick took 60.00 seconds (should be max 0.05)
[13:41:09] [Server Watchdog/FATAL]: Considering it to be crashed, server will forcibly shutdown.
[13:41:11] [Server Watchdog/ERROR]: This crash report has been saved to: /home/mc/minecraft/116/minecraft/./crash-reports/crash-2020-08-24_13.41.11-server.txt```
Will there be a fix for this? I have the exact same issue with my world hosted on a server. We crash almost every time we travel through certain chunks except when I've just booted the server. I made a portal to reach the village I want to go to and I can reproduce the same error. Same when I use the rail system we made to reach said village. So it crashes no matter if we're in the over world or in the nether.
It's been at least 2 weeks now I think since the bug started happening. I believe it was when I updated to 1.16.2
For what it's worth, I really hope to keep my world because I've been at this for a few months now with my girlfriend and we'd really hate to have to start over. Especially if the issue may just rise again. 😞
Here's the error in the server console :
[21:24:23] [Server Watchdog/FATAL]: Considering it to be crashed, server will forcibly shutdown.
[21:24:23] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:flower",config:{tries:64,yspread:3,xspread:7,need_water:0b,zspread:7,project:1b,blacklist:[L;],block_placer:{type:"minecraft:simple_block_placer"},whitelist:[L;],state_provider:{type:"minecraft:plain_flower_provider"},can_replace:0b}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:flower",config:{tries:64,yspread:3,xspread:7,need_water:0b,zspread:7,project:1b,blacklist:[L;],block_placer:{type:"minecraft:simple_block_placer"},whitelist:[L;],state_provider:{type:"minecraft:plain_flower_provider"},can_replace:0b}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:tree",config:{heightmap:"OCEAN_FLOOR",decorators:[L;],trunk_provider:{state:{Properties:{axis:"y"},Name:"minecraft:oak_log"},type:"minecraft:simple_state_provider"},minimum_size:{limit:1,type:"minecraft:two_layers_feature_size",lower_size:0,upper_size:1},max_water_depth:0,trunk_placer:{height_rand_b:0,base_height:4,height_rand_a:2,type:"minecraft:straight_trunk_placer"},leaves_provider:{state:{Properties:{distance:"7",persistent:"false"},Name:"minecraft:oak_leaves"},type:"minecraft:simple_state_provider"},ignore_vines:1b,foliage_placer:{offset_random:0,offset:0,radius:2,type:"minecraft:blob_foliage_placer",radius_random:0,height:3}}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:rotated_block_provider"}}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:flower",config:{tries:64,yspread:3,xspread:7,need_water:0b,zspread:7,project:1b,blacklist:[L;],block_placer:{type:"minecraft:simple_block_placer"},whitelist:[L;],state_provider:{type:"minecraft:plain_flower_provider"},can_replace:0b}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:flower",config:{tries:64,yspread:3,xspread:7,need_water:0b,zspread:7,project:1b,blacklist:[L;],block_placer:{type:"minecraft:simple_block_placer"},whitelist:[L;],state_provider:{type:"minecraft:plain_flower_provider"},can_replace:0b}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:tree",config:{heightmap:"OCEAN_FLOOR",decorators:[L;],trunk_provider:{state:{Properties:{axis:"y"},Name:"minecraft:oak_log"},type:"minecraft:simple_state_provider"},minimum_size:{limit:1,type:"minecraft:two_layers_feature_size",lower_size:0,upper_size:1},max_water_depth:0,trunk_placer:{height_rand_b:0,base_height:4,height_rand_a:2,type:"minecraft:straight_trunk_placer"},leaves_provider:{state:{Properties:{distance:"7",persistent:"false"},Name:"minecraft:oak_leaves"},type:"minecraft:simple_state_provider"},ignore_vines:1b,foliage_placer:{offset_random:0,offset:0,radius:2,type:"minecraft:blob_foliage_placer",radius_random:0,height:3}}}]
[21:24:24] [Server Watchdog/ERROR]: This crash report has been saved to: C:\Users\kev\Documents\Minecraft Server\.\crash-reports\crash-2020-08-26_21.24.24-server.txt
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:rotated_block_provider"}}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:tree",config:{heightmap:"OCEAN_FLOOR",decorators:[L;],trunk_provider:{state:{Properties:{axis:"y"},Name:"minecraft:oak_log"},type:"minecraft:simple_state_provider"},minimum_size:{limit:1,type:"minecraft:two_layers_feature_size",lower_size:0,upper_size:1},max_water_depth:0,trunk_placer:{height_rand_b:0,base_height:4,height_rand_a:2,type:"minecraft:straight_trunk_placer"},leaves_provider:{state:{Properties:{distance:"7",persistent:"false"},Name:"minecraft:oak_leaves"},type:"minecraft:simple_state_provider"},ignore_vines:1b,foliage_placer:{offset_random:0,offset:0,radius:2,type:"minecraft:blob_foliage_placer",radius_random:0,height:3}}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:rotated_block_provider"}}}]
[21:24:24] [Server thread/ERROR]: Input does not contain a key [type]: MapLike[{name:"minecraft:block_pile",config:{state_provider:{state:{Properties:{axis:"y"},Name:"minecraft:hay_block"},type:"minecraft:rotated_block_provider"}}}]We crash almost every time we travel through certain chunks except when I've just booted the server.
@@unknown this report here is not related to any crash. It appears what you are experiencing is MC-63590. Please have a look at that report describing how to solve it.
So it's clear for those that didn't interpret it from my last reply providing what the actual problem is here
This issue is fixed in Paper 1.16.2 - https://papermc.io/downloads
i hope this helps with the fixing of this bug
—
Edit: Removed by a moderator because it is unrelated to this issue.
@[Mod] Marcono1234 Hi! Thanks for your reply. I have read and applied the solution provided in MC-63590, however, the issue persists in a different fashion. I still get disconnected from my server (even when I'm the only player on) when I travel to the problematic destination in my world. Also the server completely freezes after I get disconnected from the server so I have to restart it.
Since I'm using a vanilla minecraft server.jar and I'm not running it through any particular third party program or modding it in any way (except I use Optifine in game), I'm under the impression that it might be an issue that hasn't been resolved. Especially since the fix provided in MC-63590 clearly isn't making the server operate as it should. I must admit though, I don't see any errors in the console after I get forcibly disconnected, that's kind of an improvement, however I can't reconnect to the server since it's frozen from that point on. So not seeing the error isn't really fixing the issue since the server doesn't work properly after I get disconnected.
As for what @Aikar mentioned after my last comment, am I to understand that I should use "paper" for the server to work properly?
P.S. Maybe I should post this in MC-63590 but... it's resolved at the moment so I'm a little confused as to where I really should be posting this.
I will delete my comments if I'm redirected somewhere else 😉
Update - I've read up on Reddit about optimal server configs and followed these instructions : https://aikar.co/2018/07/02/tuning-the-jvm-g1gc-garbage-collector-flags-for-minecraft/
I also found a video explaining what Paper is and how to install it to run my server with it. So I'm now using Paper to run my server and I can't seem to reproduce the issue so far. Hopefully this helps anyone having this issue... Also my server seems ridiculously faster than it was before? 🙂
I upgrade from 133 1.16.1 too 16.2 148 and get MapLike errors.
So the fix from @unknown fix only some of the issues.
You can still get MapLike errors.
Those errors you saw are 100% a completely different bug. I assume
Mojang, I don't know if a new issue is warranted for this one, but I don't have any more context since can't reproduce my self:
@K.Geraghty Welcome to Paper 🙂 This is what our project is known for, is improving minecrafts performance and security as well as a ton of new features for server owners.
We work pretty closely with Mojang to help bring our improvements to the base game, but sadly that process can be a bit slow... 😞
Aikar sry it so similar issue with MapLike errors and this is still open.
I can zip worlds folder and send it (I have still backups, but they are probably newer an the error i show here). ether see if a maplike is open or start new.
marcono1234
@@unknown I have removed your attachment form this report because it seems to be unrelated. However, it is quite interesting nonetheless that Watchdog shuts down the server while it is in BlockableEventLoop.waitForTasks() (indicating that it is idle?). Feel free to create a separate report (ideally also including reproduction steps) about that issue.
@@unknown, I think it would be best to create a separate issue for that (especially if it only appears after applying your fix in Paper); also please make sure that this is indeed a vanilla Minecraft issue and not an issue with the fix you implemented for Paper.
Mod turn down my issue, and say it same as this.
Either way @@unknown , yes see my other issue I start. I get Input does not contain a key [type] on vanillia.
@Broken-arrow because the logs you pasted in that ticket is in fact a duplicate of this one.
The logs you pasted on Paper's issue tracker looks to be a different issue. the key is "position_predicate" vs "type"
I linked the logs in my last reply
@Marcono, I can say with confidence my fix can not cause a regression, as it only deals with type/name. I question if Michaels issue is a similar issue but different data set with same problem though.
I cant create a ticket for that yet as michael has not provided me enough information to reproduce it yet.
I have put in lots of afford in this and all thing I can see it is this errors fault. Aikars fix alter the error and I guess it halfway fix the problem.
this error get altered in paper:
[Server thread/ERROR]: Input does not contain a key [type]: MapLike[\
All problem start with 1.15 with hay_pile errors and if electronicboy correct it is because you remove world gen features.
So i guess it better run paper on old world, an use vanillia jar server.
Issue affecting 1.16.3 as well. Every single new village I come across in unexplored map areas triggers a plethora of these errors and ends up screwing up village generation. Instead of playing, I spend half an hour or more manually filling in missing grass/sand/gravel/water blocks under and around houses and other structures just to make the area look normal again.
@Pcobald can you remove that comment? It's spam and does not add anything of value to the conversation.
Unless Mojang asks for more information, no more needs to be supplied for this issue.
So please avoid replying with more stuff until Mojang asks, though last I talked with Mojang on this issue, they seem to understand what the issue is.
This is unlikely to be fixed before 1.17.
Edit: Never mind, this doesn't really add anything, now that I understand the jigsaw block it makes sense that it would be having this issue.
Looks like this may also affect villages in general in upgrades from 1.15.2 -> 1.16.2. Unknown the specific circumstances as to when though.
I've found villages which seem to generate the issue, deleting the chunks associated which don't seem to have pillager outposts seems to resolve it. The specific village was in the savanna I think.