Players that are forced to sneak in small areas receive damage when stepping on magma blocks

The Bug:

Players that are forced to sneak in small areas receive damage when stepping on magma blocks.

Steps to Reproduce:

1. Build the setup as shown in the attachment below.

1. While sneaking and holding the sneak key, stand on top of the magma block.

2. Stop holding the sneak key.

3. Take note as to whether or not players that are forced to sneak in small areas receive damage when stepping on magma blocks.

Observed Behavior:

Players that are forced to sneak in small areas receive damage when stepping on magma blocks.

Expected Behavior:

Players that are forced to sneak in small areas would not receive damage when stepping on magma blocks.

Code Analysis:

Code analysis by @unknown can be found below.

The following is based on a decompiled version of Minecraft 1.19.2 using MCP-Reborn.

net.minecraft.world.level.block.MagmaBlock.java

public class MagmaBlock extends Block {
   ...
   public void stepOn(Level level, BlockPos blockPos, BlockState blockState, Entity entity) {
      if (!entity.isSteppingCarefully() && entity instanceof LivingEntity && !EnchantmentHelper.hasFrostWalker((LivingEntity)entity)) {
         entity.hurt(DamageSource.HOT_FLOOR, 1.0F);
      }
      super.stepOn(level, blockPos, blockState, entity);
   }
   ...

If we look at the above class, we can see that in order for the player to receive damage from stepping on magma blocks, the isSteppingCarefully() boolean must return false. This boolean returns true if the shift key is held down or is toggled and returns false if the shift key isn't held down or isn't toggled. The game doesn't check if the player is being forced to sneak in small areas before allowing them to receive damage from stepping on magma blocks, therefore resulting in this problem occurring.

Fix:

Simply altering the existing "if" statement within this piece of code to check if the player is being forced to sneak in small areas before allowing them to receive damage from stepping on magma blocks will resolve this problem. We can achieve this through the use of the isCrouching() boolean.

Current "if" statement:

if (!entity.isSteppingCarefully() && entity instanceof LivingEntity && !EnchantmentHelper.hasFrostWalker((LivingEntity)entity))

Fixed "if" statement:

if (!entity.isCrouching() && entity instanceof LivingEntity && !EnchantmentHelper.hasFrostWalker((LivingEntity)entity))