mojira.dev
MC-219892

Falling from cave vines and dying uses death.fell.accident.other_climbable, instead of a specified death message

The death message I got by falling from cave vines is "<player> fell while climbing"; it should be "<player> fell off some cave vines" or something along those lines.

How to reproduce:

  1. Place a block at least 25 blocks above the ground using /setblock.

  2. Place two cave vines using glow berries below the block.

  3. Fly into and stay in the cave vines in creative mode.

  4. Switch to survival mode and let yourself fall and die.

  5. Look at the death message.

Expected result:

The death message would be something close to "<player> fell off some cave vines".

Observed result:

The death message was "<player> fell while climbing".

Cause:

Living entities have a CombatTracker, which tracks the details of damage recently taken. When taking damage, CombatTracker#recordDamage is run, which tracks the damage, and that method runs prepareForDamage, which checks for climbable blocks. That method does not contain a check for Blocks.CAVE_VINES or Blocks.CAVE_VINES_PLANT.

Related issues

Attachments

Comments

migrated
[media][media][media]
Avoma

After some research on crowdin, according to the official source strings for EN_US, there is no dedicated string for this death message and as a result of this, the death message "death.fell.accident.other_climbable", is displayed instead. A new string would need to be added in order to fix this issue.

Avoma

Video attached.

muzikbike

Relates to MC-173484, MC-173485, and possibly MC-181284 and MC-206558

Avoma

Can confirm in 21w13a.

Avoma

Can confirm in 21w14a.

Avoma

Can confirm in 21w15a.

Avoma

Can confirm in 21w16a.

Avoma

Can confirm in 21w17a.

Avoma

Can confirm in 1.17.

Avoma

Can confirm in 1.17.1.

Avoma

Can confirm in 1.18.1.

pulpetti

In 1.19 Pre-2.

batbrain1998

Can confirm in 1.19 RC1.

Avoma

Can confirm in 1.19.

[media]

[Mod] ManosSef

(Unassigned)

Confirmed

Gameplay

Low

Player, Text

21w11a, 21w13a, 21w14a, 21w15a, 21w16a, ..., 24w34a, 24w39a, 1.21.3, 1.21.4, 1.21.5

Retrieved