Steps to reproduce:
Place candles on a block
Remove the block under the candles so that they float in the air
Waterlog the candles by using a water bucket on them
Remove the source water block, for example with an empty bucket or a sponge
Result:
The candles are broken and they drop as items.
Expected result:
Only the water is removed, and the candles stay in the air.
Code analysis:
Code analysis by @unknown can be found in this comment.
Linked issues
Attachments
Comments 9
I can confirm this behavior in 1.19.2. This problem can also be seen when water is removed from waterlogged candles that have non-solid blocks below them, such as honey blocks and leaves.
Here's a code analysis regarding this issue along with a fix.
Code Analysis:
The following is based on a decompiled version of Minecraft 1.19.2 using MCP-Reborn.
net.minecraft.world.level.block.CandleBlock.java
public class CandleBlock extends AbstractCandleBlock implements SimpleWaterloggedBlock {
...
public boolean canSurvive(BlockState blockState, LevelReader levelReader, BlockPos blockPos) {
return Block.canSupportCenter(levelReader, blockPos.below(), Direction.UP);
}
...Looking above, we can see that the canSurvive() method is present within the CandleBlock.java class. This method basically restricts candles from being able to be placed unless certain requirements are met. In this particular case, only one requirement is needed, and this is that the block below the desired location of placement must be solid and able to support the center of a candle block. Since blocks such as air and leaves are not considered solid, candles cannot be placed on top of these blocks.
So why is this relevant? Well basically, every time the block state of a candle changes, the canSurvive() method is called and checks if the block below the candle is still solid and still able to support its center. If it is, the candle will not be destroyed, but if it isn't, the candle will be destroyed, thus resulting in this problem occurring.
Fix:
Simply removing the canSurvive() method from the CandleBlock.java class will prevent waterlogged candles that are floating or have non-solid blocks below them from being destroyed when the water within them is removed, thus fixing this issue.
Can confirm. Also affects 1.17 Pre-release 3.