mojira.dev
MC-226727

Several advancements use multiple criteria instead of the new "items" format

fishy_business, tactical_fishing, obtain_armor and shiny_gear advancements use multiple criteria of the same trigger (fishing_rod_hooked and inventory_changed) testing for one item each. For example, the fishy_business advancement is:

{
  "parent": "minecraft:husbandry/root",
  "display": {
    "icon": {
      "item": "minecraft:fishing_rod",
      "nbt": "{Damage:0}"
    },
    "title": {
      "translate": "advancements.husbandry.fishy_business.title"
    },
    "description": {
      "translate": "advancements.husbandry.fishy_business.description"
    },
    "frame": "task",
    "show_toast": true,
    "announce_to_chat": true,
    "hidden": false
  },
  "criteria": {
    "cod": {
      "trigger": "minecraft:fishing_rod_hooked",
      "conditions": {
        "item": {
          "items": [
            "minecraft:cod"
          ]
        }
      }
    },
    "tropical_fish": {
      "trigger": "minecraft:fishing_rod_hooked",
      "conditions": {
        "item": {
          "items": [
            "minecraft:tropical_fish"
          ]
        }
      }
    },
    "pufferfish": {
      "trigger": "minecraft:fishing_rod_hooked",
      "conditions": {
        "item": {
          "items": [
            "minecraft:pufferfish"
          ]
        }
      }
    },
    "salmon": {
      "trigger": "minecraft:fishing_rod_hooked",
      "conditions": {
        "item": {
          "items": [
            "minecraft:salmon"
          ]
        }
      }
    }
  },
  "requirements": [
    [
      "cod",
      "tropical_fish",
      "pufferfish",
      "salmon"
    ]
  ]
}

Instead, they should use a single criterion testing for each item in the items list.
The updated fishy_business advancement would be:

{
  "parent": "minecraft:husbandry/root",
  "display": {
    "icon": {
      "item": "minecraft:fishing_rod",
      "nbt": "{Damage:0}"
    },
    "title": {
      "translate": "advancements.husbandry.fishy_business.title"
    },
    "description": {
      "translate": "advancements.husbandry.fishy_business.description"
    },
    "frame": "task",
    "show_toast": true,
    "announce_to_chat": true,
    "hidden": false
  },
  "criteria": {
    "fish": {
      "trigger": "minecraft:fishing_rod_hooked",
      "conditions": {
        "item": {
          "items": [
            "minecraft:cod",
            "minecraft:tropical_fish",
            "minecraft:pufferfish",
            "minecraft:salmon"
          ]
        }
      }
    }
  },
  "requirements": [
    [
      "fish"
    ]
  ]
}

Comments 2

Can confirm in 1.17

You're suggesting a change to the code, and not reporting a bug.

Aeldrion

(Unassigned)

Community Consensus

Advancements

1.17 Pre-release 1, 1.17

Retrieved