The bug
When clicking on the "Purchase Now!" CTA in the Demo Mode introduction popup, the Minecraft Store link is immediately opened, without showing the link confirmation ("Do you want to open this link...?") screen.
This is inconsistent with other buttons in the game's UI that open a web link.
To reproduce
Run the game in Demo mode. (You can do this manually by specifying the correct arguments to the
client.jaror you can select a Mojang account that has not brought the game in the Launcher.)Click "Play Demo World" to generate/enter the demo world.
When the Demo Mode introduction popup appears, click the "Purchase Now" button on the left.
Code analysis (Official Mappings)
Other buttons
When any other button that opens a link is clicked, the callback function looks something like this:
this.minecraft.setScreen(new ConfirmLinkScreen($$0 -> {
if ($$0) {
Util.getPlatform().openUri(GUIDE_LINK);
}
this.minecraft.setScreen(this);
}, GUIDE_LINK, true));As you can see, the whole thing is wrapped in a ConfirmLinkScreen that will only open the link if the "Yes" button is clicked.
Purchase Now! button
However, when the "Purchase Now!" button is clicked, this callback is executed:
$$0.active = false;
Util.getPlatform().openUri("http://www.minecraft.net/store?source=demo");This simply disables the button and then directly opens the URL, without opening a ConfirmLinkScreen. It should probably look similar to the first example.
Screenshots
The Demo Mode introduction popup:
[media]Attachments
Comments 2
While you are correct in saying that the link is hardcoded and therefore can likely be trusted, it is also useful to know the target of a link before you click it and have the option to copy the link so that the web page can be opened manually. (As provided by web browsers, for example.) Also, there's no indication that the button is opening a web page - you could reasonably expect the purchase to happen in-game or through the launcher.
Finally, note that every other link in the game's menus uses the confirmation screen, even though they are also hardcoded. Therefore the fact that the purchase link directly opens is inconsistent with how the rest of the UI operates, making it even more likely to cause confusion.
[media]
This may be WAI; the link confirmation is presumably there so you can see the actual URL and decide if it's safe to go to that site, but this link in particular is put there by the devs and goes to a trusted site.