[MC-251617] Advancement trigger player_killed_entity checking for an entity's dimension always checks for the player's dimension instead

Setting the location.dimension field of the entity condition in player_killed_entity will not make the advancement check for the entity's dimension, but the dimension the player that will get the advancement is in.

How to reproduce:

Summon a ghast with no AI in the nether.
Use /forceload add on the chunk the ghast is in, or have another player stand close to the ghast to make sure it is loaded.
Place a TNT block next to it.
Light the TNT using flint and steel or a fire charge and go through a nether portal before it explodes.
→ ❌ You just got the advancement "Uneasy Alliance", even though the ghast was in the nether.

Expected result:

The advancement would require the ghast to be in the overworld.

Observed result:

Only the player is required to be in the overworld.

Code analysis:

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 1

MC-271728 Location of the victim entity for "player_killed_entity" advancement trigger is evaluated in the dimension of the player Resolved

Comments 1

Misode 2022-05-12T21:32:47Z

The issue is that the LocationPredicate#matches method only receives (serverLevel, x, y, z). It uses the serverLevel to check the dimension. When KilledTrigger#trigger tests the EntityPredicate, it always uses the player's server level from the LootContext, instead of the level of the entity. This probably affects all entity predicates.