The bug:
When brewing a single Dragon Breath no glass bottle is returned to the player. When brewing 2 or more a glass bottle is returned to the player as expected.
How to reproduce:
In a brewing stand place 2 (or more) Dragon Breath in the input slot and a single awkward potion.
With 1 blaze powder brew one lingering potion.
Note the glass bottle is dropped in the world.
Brew another potion using up the last Dragon Breath
Note that no glass bottle is dropped in the world or retained in the inventory of the brewing stand.
Expected behaviour:
A glass bottle is retained in the input slot or dropped into the world after brewing the last Dragon Breath.
Many thanks, please let me know if you need any more info.
Linked issues
is duplicated by 1
relates to 1
Attachments
Comments 5
What the original issue MC-86007 neglects to mention, and what this issue does mention, is how the Glass Bottle is dropped in-world if there are multiple Dragon's Breath items in the input slot, but not if there is only one. This inconsistent behaviour, and a code analysis, makes it very clear that this is a bug and certainly should not be marked as Works as Intended like that original issue was.
It's worth mentioning that the code analysis indicates the intended behaviour is that a Glass Bottle would be retained in the input slot of the Brewing Stand in this scenario. The reason it doesn't is because the method call to get the stack's recipe remainder is done after the stack is already made empty, thereby essentially getting the recipe remainder of Air. This is clearly the cause of this bug.
A potential reason why that seemingly intended behaviour might not be desirable is that it might break automatic brewing systems, as Hoppers cannot pull items from the input slot of a Brewing Stand. A solution that would fix the issue whilst avoiding said undesirable breakages is to simply always drop the recipe remainder in the world, rather than ever trying to insert it into the input slot.
This issue is still present on Minecraft 1.19.4 release candidate 3. The bottle put in one of the three lower slots should be a splash potion to brewed into a lingering potion by dragon's breath.
It seems there's a misunderstanding regarding the original report. In snapshot 15w33c (part of version 1.9), the issue referenced as MC-86007 was resolved. The fix ensured that if only one dragon's breath was placed in the slot during the brewing process, the empty glass bottle would occupy the slot upon completion. However, if multiple dragon's breath items were inserted, the empty bottle would be dropped as an item.
However, in snapshot 16w32a (the first snapshot for version 1.11), the mechanic of placing the empty bottle into the slot when only one dragon's breath was added was removed. This change was made due to feedback highlighting an additional step in automatic brewing machines. Nevertheless, the mechanic of dropping the glass bottle as an item when multiple dragon's breath items are inserted was retained to allow players to reclaim the empty bottle.
Subsequently, in version 1.11, the ability to retrieve the bottle after inserting only one dragon's breath was removed, leading to the reopening of MC-86007. Mojang later marked this as WAI (Working As Intended), indicating that it's intentional that players no longer receive the bottle back in such scenarios.
In essence, there is no inherent issue here. Automatic brewing machines can simply insert one dragon's breath into the slot without the inconvenience of dealing with the empty bottle. If players desire to retrieve the empty bottle, they can easily achieve this by inserting multiple dragon's breath into the slot.
Dupe of MC-86007