mojira.dev
MC-260264

Cherry Grove doesn't use colormaps for grass or foliage

Resolved
Works As Intended
2

The cherry grove biome appears to either have hardcoded grass or foliage colors or pulls the values from somewhere else. The grass.png and foliage.png files in resource packs don't influence the color at all.

The attached screenshots both show the border between a plains biome (left) and a cherry grove biome (right).  In the screenshot where all the grass is green, it's using the normal grass.png from the current resource pack. In the second screenshot, it's using a grass.png that's been inverted to shades of purple. The plains biome exhibits the expected behavior and the grass is purple, but the cherry grove biome's grass stays the same shade of green as the first screenshot. Foliage in the cherry grove biome similarly ignores foliage.png.

Just in case, I also tried this with a resource pack that only contains a grass.png file in the colormaps directory, with the same result, so this is not isolated to a particular resource pack.

Linked issues

is duplicated by 1

Attachments

2023-02-16_13.02.35.png 2023-02-16_13.03.59.png 2023-02-16_13.21.56.png 2023-02-16_13.22.08.png

Comments 4

It appears this is caused by grass_color being defined in cherry_grove.json. Below is a snippet of the effects object in said file:

"effects": {
    "fog_color": 12638463,
    "foliage_color": 11983713,
    "grass_color": 11983713,
    "mood_sound": {
      "block_search_extent": 8,
      "offset": 2.0,
      "sound": "minecraft:ambient.cave",
      "tick_delay": 6000
    },
    "music": {
      "max_delay": 24000,
      "min_delay": 12000,
      "replace_current_music": false,
      "sound": "minecraft:music.overworld.cherry_grove"
    },
    "sky_color": 8103167,
    "water_color": 6141935,
    "water_fog_color": 6141935
  },

As you can see, grass_color, which overrides the normal behavior of grass color being selected on the colormap due to temperature and downfall, is set to 11983713, which when converted to hexadecimal is {color:#B6DB61}⬤#B6DB61{color}. This is probably intended as it makes the color more pretty than it would normally be. You can override this using a datapack.

Given how they are exclusively per-world or per-server, installing a datapack just to change the grass color seems like something that just really shouldn't be necessary. Colors for grass and foliage, along with pretty much all other visuals, are traditionally controllable by the resource pack, and anything else is just weirdly inconsistent with established functionality. It's especially weird given that the developers are able to adjust the colormap however they see fit, up to and including adding little blob of #B6DB61 wherever the Cherry Grove's single pixel would end up on there based on the temperature and humidity values. 

I don't think anyone would disagree that resource packs are an extremely important part of Minecraft, and they're designed specifically to have their own looks in terms of visual style and color palette. If this decision was intentional, and we can expect more biome colors to be unchangeable without datapacks in the future, it's just kind of a slap in the face to resource packs in general.

They really should make foliage (and water, fog, sky etc) colors fully customizable by resource packs. Have data packs define the colors in the biome files, and allow resource pack to override them.

Could you at least explain why this works as intended?
Why would you make resource packs unable to change something like this?

pkfortis

(Unassigned)

Confirmed

Resource Packs

23w07a

Retrieved