[MC-263080] The name tags of wardens are partly inside their models

The Bug:

The name tags of wardens are partly inside their models.

Steps to Reproduce:

Summon a warden with a custom name by using the command provided below.

/summon minecraft:warden ~2 ~ ~ {NoAI:1b,Silent:1b,Rotation:[90f,0f],CustomNameVisible:1b,CustomName:"{\"text\":\"Very Long Warden Name\"}"}

Look at the positioning of the warden's name tag.
Take note as to whether or not the name tags of wardens are partly inside their models.

Observed Behavior:

The name tags are partly inside the said entity model.

Expected Behavior:

The name tags would be above the said entity model.

Code Analysis:

Code analysis by @unknown can be found in this comment.

Linked issues

relates to 2

MC-260105 The name tags of sniffers are partly inside their models Resolved

MC-262789 The name tags of hoglins are partly inside their models Open

Attachments

Comments 1

Apollo30 2023-08-01T12:06:24Z

Fix:

No code analysis needed, a simple fix is to override the super method by using it's current name tag offset and then add 0.3F to the height. Then it'll correctly position the Warden's Nametag.

net.minecraft.world.entity.monster.warden.Warden.java // Updated

public class Warden extends Monster implements VibrationSystem {
    public float getNameTagOffsetY() {
        return super.getNameTagOffsetY() + 0.3F;
    }
}

[media]