[MC-271739] Scute items from a baby turtle growing up are spawned too high

Scutes spawned from a baby turtle when they grow up will be positioned too high above the entity.

Steps to Reproduce:

Tick freeze the game for observation:
```
/tick freeze
```

Summon a turtle 1 tick away from growing up:

/summon minecraft:turtle ~ ~ ~ {NoAI:1b,Age:-1}

Advance the game by 1 tick
```
/tick step 1
```

Observed Behavior:

The scute will be positioned too high above the turtle entity.

Expected Result:

The scute would be positioned directly above the top of the turtle when it grows up, similar to other items created from entities by game events/interactions.

Screenshots/Videos:

Showcase of the scute item spawning compared to other items created by game events:

[media]

Notes:

Code analysis by @unknown in the pinned comment
Related to: MC-262667 MC-269147 MC-270213

Attachments

SpawnedItems.mp4

Comments 3

BugTracker 2024-05-08T13:57:10Z

Can confirm.

[media]

Avoma 2024-05-10T10:38:07Z

Can confirm. The scute is indeed spawned up too high.

haykam 2024-05-16T18:34:16Z

Code analysis (Yarn mappings)

The turtle scute dropping behavior is implemented in the TurtleEntity#onGrowUp method:

@Override
protected void onGrowUp() {
	super.onGrowUp();

	if (!this.isBaby() && this.getWorld().getGameRules().getBoolean(GameRules.DO_MOB_LOOT)) {
		this.dropItem(Items.TURTLE_SCUTE, 1);
	}
}

As indicated by the integer literal 1, the item entity will be spawned 1 block above the Y position of the turtle's feet. Note that turtles are 0.4 blocks high and baby turtles are 0.12 blocks high, so this offset is far away from the turtle.

Because a hardcoded offset is used, this also means that the turtle's scale attribute will not affect the item entity's position.