mojira.dev
MC-29844

Big Oak Trees fail to generate in Forest Biomes

Big Oak Trees completely fail to generate in Forest, Flower Forest, etc ...
This bug seems worse than MC-11208 since big trees doesn't even attempt to generate, instead of being generated weirdly
In jungle biomes, however, they are replaced by trees with generical spherical foliage

Steps to reproduce :
_Find a Biome in which Oak Trees can spawn naturally
_Notice how Big Oak Trees are missing

Alternate way :
_Create a superflat world of a Forest for exemple with decorations enabled
_Notice how Big Oak Trees are missing


Turns out it's a so-called "FPS fix" by @unknown

http://www.reddit.com/r/Minecraft/comments/1m97cw/while_you_are_all_crying_over_the_name_change_of/

The reason they got removed was because they don't follow the leaf decay rules, and thus caused a LOT of chunk updates. I basically doubled my FPS in forests by removing these.

My intention was not to remove them completely, though, but rather "fix them later". The problem now is that the code for those trees is super-complex, and not the easiest thing to work with.

Problem description: Leaves must be placed so they are connected via other leaves to a tree trunk, max 4 steps away. Where's the bug?
...

BigTree source code from Jeb:

[media]

Paul Spooner, original maker of Forester Filter and gave the Big Tree generation code to Notch, says:

The stuff you're looking for is in the "foliageShape" function. I suggest replacing the line:

else if ((y == 0) || (y == (foliageHeight - 1))) return (float) 2;

with the following two lines

else if ((y == 0) || (y == (foliageHeight - 2))) return (float) 2;
else if (y == (foliageHeight - 1)) return (float) 1.5;

The change should reduce the size of the foliage clusters and prevent decay.

Linked issues

Attachments

Comments 51

galaxy_2alex

Hm... could be intentional, but we don't know exactly. Allthough, this is still a Duplicate of MC-11208, possibly with another reason.

_zombiehunter

So MC-30408 was closed as a dublicate of this? OK, fine, but still two things to do here:
1.) Upvote this, everyone. Upvote.
2.) Someone please add 13w37b to the versions list.
Thanks !

Missingno_26

added 13w37b to affected versions

Atom clark

you realise they still generate in Jungles

_zombiehunter

@Atom clark:
Show me one screenshot with a big oak tree in a jungle biome. With "big", I mean this size: http://media-mcw.cursecdn.com/9/99/TreeComparison.png.
I can't remember them generating in any jungle biome in 1.6.2 (which seems to be intended). But now, they are missing everywhere.

41 more comments
Ivan

Brand new world on 1.10.2 - about the new attachment

user-f2760

Seed?

Ivan

-2185075754171440691

Skylinerw

Could not reproduce with given seed, see image.

Ivan

Ran 1.10 and then 1.10.2 again and they it got fixed. Probably something got messed up.

Missingno_26

Erik Broes

Community Consensus

Minecraft 13w36a, Minecraft 13w36b, Minecraft 13w37a, Minecraft 13w37b, Minecraft 13w39a, ..., Minecraft 14w21b, Minecraft 1.7.10-pre3, Minecraft 14w34c, Minecraft 1.8, Minecraft 1.8.1

Minecraft 15w44a

Retrieved