mojira.dev
MC-299162

No error is printed to the game output log if the texture for burning entities cannot be loaded

Normally, textures from blocks.png-atlas will produce error messages if they cannot be loaded, since this results in use of the missing texture, which indicates an error somewhere. However, for the specific case of the fire texture used on entities and in first person, no such error is displayed, which is wrong.

This may have been responsible for the fire overlay not loading in at least two snapshots so far: MC-56852, MC-129616 - were these reported in the game log, the absent textures could have been caught before release and resolved accordingly.

How to reproduce: a resource pack is attached to this ticket which unloads the fire textures, pointing fire as a block to a new, dedicated model. Apply this resource pack, observe the game log, and then set yourself or some other entity on fire. Expected results would be for an error to be printed in the log indicating that the fire texture could not be found, but this does not happen.

Potential fix: instead of loading the “on fire” texture from the texture atlas, it could be its own, separate texture (would fix MC-270233 and could also fix MC-276666). Alternatively, we could resort to using particles instead like is done in Bedrock Edition (https://github.com/Mojang/bedrock-samples/blob/main/resource_pack/textures/flame_atlas.png ).

Attachments

Comments 0

No comments.

muzikbike

(Unassigned)

Unconfirmed

(Unassigned)

1.21.6, 1.21.7 Release Candidate 2

Retrieved