BadOmen & RaidOmen are discarding hiddenEffects on activation

Every effect in the game supports the feature of “hiddenEffects” where if you receive an effect of a lower level but a longer duration of what you already have, the lower effect will be stored in an “hiddenEffect” field to be restored once the bigger effect runs out.

RaidOmen and BadOmen are broken in this regard, since they will discard their pile of hiddenEffect when triggering their effect which seems to be an unforseen side effect of the following chain of events :

• BadOmenStatusEffect/RaidOmenStatusEffect’s applyEffectTick function returns false to signify that its one-time-effect has been activated

• MobEffectInstance’s tickServer function forwards this result

• LivingEntity’s tickEffects function react to this return value by simply calling iterator.remove() to remove the effect from the player. <--- this disregards the presence of any hiddenEffect on the effect being removed !

We can see here that the hidden effect, despite having 42 ticks more than the main one, got removed from my Player at the same time that the main one triggered :

I would expect the logic of MobEffectInstance.downgradeToHiddenEffect (or similar) to be applied when the main effect is removed.