Bucket duplication with datapacks

The Bug

Buckets are able to be duplicated in crafting recipe datapacks that have inputs of Water, Lava or Milk Buckets and outputs of any type of bucket item (Milk, Water, Fish Buckets etc.)

Reproduce

• Download the attached datapack

• Load it onto a world

• Put a Milk Bucket in a Crafting Table (Should get a Lava Bucket)

• Get the output item

• Notice how you have a remainder of a bucket

• Place the output item (Should be a lava bucket)

• You now get a 2nd bucket

Explanation

This is because Milk, Water & Lava Buckets all have a crafting remainder of a Bucket. So once an item with a Milk, Water or Lava Bucket is crafted a bucket is left behind.

Why Is It A Problem

The problem is albeit very small with very little consequence to vanilla. The real problem comes with datapacks/mods. There’s no way for a recipe to prevent a crafting remainder causing duplication issues like the Bucket. This can cause various issues on servers/mods where they use one of the three items as a crafting recipe into lets say a Sulfur Cube Bucket. Once the new Bucket of XYZ is placed now they have two buckets, hence the duplication.

Potential Solutions

1. Add a way to prevent crafting remainders in recipe json files

2. Add a check to see if the input & output have the same crafting remainder and prevent the input from creating a remainder item