[MC-3794] Chest direction placing glitch

The bug

When placing a chest it will glitch to another direction for a second.

How to reproduce

Place a chest when you are facing north
Place a chest in front of it
You can see a double chest to another side for half a second

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 3

MC-9871 Double chest conflict when chest are in two different directoins. Resolved

MC-11241 Double chest visual glitch Resolved

MC-31339 Double chest placing graphical glitch Resolved

Attachments

Comments 9

CubeTheThird 2012-11-25T19:09:53Z

Can confirm.

Tails 2013-01-16T02:57:07Z

Same with trapped chests.

Leif Messinger 2013-02-19T01:46:44Z

Sorry that i duplicated, i tried to search "double chest glitch" and i went through 61 bugs. I tried.

CubeTheThird 2013-02-21T19:36:10Z

Added some labels for future reference.

marcono1234 2014-07-27T11:46:45Z

Confirmed for

14w30c
14w31a
Minecraft 1.8-pre 1 also sometimes when breaking a double chest

qmagnet 2014-08-16T01:28:05Z

Confirmed for 14w33c

marcono1234 2015-09-11T11:27:40Z

Confirmed for

15w37a

Immaterialise 2016-02-17T19:01:31Z

Confirmed for 1.9-pre1

marcono1234 2016-05-05T22:08:22Z

Please link to this comment in the description

The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.

The reason for this is very likely that the method net.minecraft.block.BlockChest.onBlockPlaced(World, BlockPos, EnumFacing, float, float, float, int, EntityLivingBase) is not calling the method net.minecraft.block.BlockChest.checkForSurroundingChests(World, BlockPos, IBlockState).

This might be inefficient because the method net.minecraft.block.BlockChest.onBlockAdded(World, BlockPos, IBlockState) is doing this always, whereas the method mentioned before and the method net.minecraft.block.BlockChest.onBlockPlacedBy(World, BlockPos, IBlockState, EntityLivingBase, ItemStack) do this when the chest is placed by a player, which means the same tests are done three times at the end.