[MC-5306] Enchanted blocks don't show enchantment in your hand, inventory, as headwear (skulls/pumpkins) or when dropped on the ground

When you combine a block with an enchantment with enchanted books while the block is in your hand or on the ground the block does not show the enchated glow to any players. It only glows in your inventory.

Linked issues

is duplicated by 3

MC-11620 If you enchant block with any enchant book in gamemode 1, you"ll see it enchanted in the inventory, but not in the hand Resolved

MC-21317 Enchanted headware such as Heads and Pumpkins do not look enchanted on player Resolved

MC-28404 Wearing an enchanted head/pumpkin will not show the enchantment in F5/multiplayer. Resolved

Attachments

Comments 16

Zuriki 2012-12-24T08:13:46Z

Related to MC-5308

To quote myself:
For all intents and purposes this "works as intended". Blocks can't save the meta-data required to remember names and enchantments. The feature wasn't really intended to be used for those items.

Recommendation to Mojang: Implement a check that the item doesn't have an ID of less than 256 (plus any special cases like Cake and Flower Pots) to make sure people don't waste XP renaming items that can't always remember the necessary meta-data. Make exception for creative mode, because renaming blocks like levers might be useful for adventure maps to name keys.

WolfieMario 2012-12-24T13:48:48Z

Blocks in the inventory can still keep that data, so there's no reason they shouldn't be able to glow in your hand.

Tails 2012-12-24T13:50:51Z

Adjusted title as blocks not showing enchanting on the ground is intended.

Zuriki 2012-12-24T17:43:09Z

Blocks in the inventory can still keep that data, so there's no reason they shouldn't be able to glow in your hand.

Well the blocks are rendered differently to regular items. Items use a flat 2D graphic and mask a texture over them, blocks use a 3D representation of the block and therefore they can't reuse the same code to render enchantments. Regardless my main point, these items should be blocked from enchantments and renames for the most-part.

WolfieMario 2012-12-24T19:10:04Z

Blocks render as 3D in your inventory and in your hand. However, they only glow in your inventory. Items render in 2D in your inventory, and 3D in your hand and on the ground, and glow in all situations. Armor also glows in its 3D render when equipped, as do blocks worn on the head. I think the block-in-hand thing is just an oversight, considering an enchanted block on a monster's head will glow just as well as it will in your inventory.

And where's the fun in blocking enchantments and renames? It's not even possible to enchant them without creative mode or external editors - it doesn't do any harm to a player in survival, and it can be put to great use in adventure maps.

6 more comments

Cameron Bess 2012-12-24T22:39:03Z

Just to clarify When I refer to "on the ground" I dont mean when placed (although that would be cool) I am referring to when you "Q" the entity out of you.

Zuriki 2012-12-25T01:08:02Z

Gerrard Lukacs, each of those situations is dealt with by a different special case in the code. Blocks worn in the head slot use the typical armor mesh and just change the texture of the mesh, which has attached to it some code which applies the glow. Items held in the hand are also not rendered the same as blocks, they use a different piece of code to generate the item sprites, this also allows them to apply the glow. In the inventory the 3D blocks can probably glow due to how the mask is applied in that particular situation (which is different to held items and dropped items again).

Regardless, my initial recommendation still stands.

WolfieMario 2012-12-25T04:54:22Z

Blocks in the head slot do not use the armor mesh. Equip an anvil as a hat and you'll see how wrong that statement is.

Also, it turns out I was wrong as well: blocks as headgear don't render their enchantment.

I realize the rendering of the inventory, the rendering of 3D items, the rendering of armor, and the rendering of blocks are different matters in the code. That still does not make it prohibitive, in any way whatsoever, to make blocks capable of rendering their enchantments in all situations in which items render enchantments. If you look at enchanted items in your hand, on the ground, and in item frames, they render their enchantments perfectly fine. I fail to see how the code rendering the enchantment on this 3D model would be impossible to apply, within reasonable feasibility, to the simpler models which most blocks use.

Your initial recommendation is off-topic here: this issue report has nothing to do with placing blocks on the ground, which obviously cannot feasibly be made to retain enchantment data. And your recommendation even says to make an exception for creative mode - thus, as it already is right now, it would still be possible to produce enchanted blocks in-game. You haven't really made any case for why a block which does have an enchantment should only render its enchantment in certain situations. This really does not strike me as something which is impractical to implement, but rather an oversight considering enchantments on blocks were not even possible until recently.

FireHunterX 2012-12-25T05:00:22Z

It's funny because you can't wear blocks on your head...
I'm lost...

WolfieMario 2012-12-25T05:41:59Z

It's actually possible to wear blocks on your head with level editors or hacked NBT data. You may encounter mobs with blocks on their heads in various adventure maps, or see players on servers wearing them (usually by the actions of an administrator). Also, you can equip pumpkins and mob heads, which are blocks.

WolfieMario 2013-10-23T17:53:43Z

Confirmed 1.7.1.

Can this ticket please be updated? As of 1.7, enchanted blocks will not even glow in the inventory anymore.

WolfieMario 2013-12-12T03:53:20Z

Confirmed for 1.7.4.

WolfieMario 2014-01-26T22:37:15Z

Confirmed for 14w04b.

Can the ticket please be revised to acknowledge that the blocks also fail to glow in the inventory?

WolfieMario 2014-04-06T20:47:13Z

Confirmed in 14w11b. Can the version tags please be updated?

EDIT: Thank you, Mod Tails.

Itouch2 2014-04-25T17:53:39Z

Confirmed for 1.7.9 and 14w17a

Itouch2 2014-06-23T11:04:00Z

Fixed in 14w25b (except for skull or pumpkin as headwear, but I do think that it is intended.)