[MC-63714] Zombified piglins get angry when hit in creative mode

The bug

Zombified Piglins (Zombie Pigmen) get angry when hit in Creative mode and remain angry when switching to Survival mode afterwards.

Expected would be that hitting a Zombified Piglin in Creative mode should not make them angry.

Reproduction steps

Spawn a Zombified Piglin
If not already, change to Survival or Adventure mode
:info: The Zombified Piglin does not attack you
Switch to Creative, and hit the Zombified Piglin
Switch back to Survival or Adventure (e.g. using F3 + F4)
❌ Now the Zombified Piglin attacks you, even though you were in Creative mode when you hit it

Code analysis

See this comment (likely outdated).

Linked issues

Attachments

2019-06-08 08-03-57.mp4

Comments 18

KingSupernova 2015-01-29T03:52:32Z

Confirmed in 1.8.2-pre5.

Sonicwave 2015-07-30T20:20:45Z

Confirmed in 15w31b.

EDIT: In fact, I'm now having pigmen attack while in Creative and Spectator. It happens if I aggro them, get out of range, then come back in Creative mode.

ProfMobius (Thomas Guimbretiere) 2016-01-12T10:35:55Z

This is both fixed/couldn't reproduce.

I think this got fixed automatically when I fixed the aggro behavior while in creative for the wolves.

marcono1234 2016-01-13T19:26:17Z

Not fixed for 16w02a

marcono1234 2016-04-10T14:15:52Z

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

Affects probably all mobs, for example also Endermen. Punching one in Creative mode and switching to Survival mode causes the Enderman to become aggressive even if you did not stare at it.

It looks like the reason for this is, that the following methods do not test if the entity is a valid target, which is for example not the case if the player is in creative mode:

net.minecraft.entity.EntityLivingBase.setRevengeTarget(EntityLivingBase)
net.minecraft.entity.EntityLiving.setAttackTarget(EntityLivingBase)
net.minecraft.entity.monster.EntityPigZombie.setRevengeTarget(EntityLivingBase)
net.minecraft.entity.monster.EntityPigZombie.becomeAngryAt(Entity)

Note: The method net.minecraft.entity.ai.EntityAITarget.isSuitableTarget(EntityLiving, EntityLivingBase, boolean, boolean) does some tests, maybe it could be used in some way.

8 more comments

Asteraoth 2019-06-08T12:19:15Z

Reopening as it wasn't fixed in 18w15a, see

[media]

violine1101 2020-06-04T20:18:08Z

Cannot reproduce in 1.16-pre1. Assuming this is fixed?

eandr127 2020-06-05T00:13:32Z

Yes, it is fixed now.

user-189af 2020-08-30T11:27:20Z

This is NOT fixed. I punched a zombified piglin in creative and went into survival and it started to attack me.

marcono1234 2020-08-30T13:49:22Z

@@unknown does MC-146524 describe your issue? If not please search and otherwise create a new report referring to this report here.

eandr127 2020-08-30T14:37:02Z

It seems that the behaviour was reverted in 1.16-pre3, so this ticket should be reopened.

user-189af 2020-08-30T15:58:19Z

Sort of, but this report is basicallly it, I hit a zombified piglin, then go into survival after a few seconds, then i start getting attacked, not in creative though.

marcono1234 2020-08-30T16:56:45Z

Thanks for pointing that out. It appears in current versions you have to switch to Survival mode shortly afterwards, waiting more than about 5 seconds does not cause this bug. I have updated the report description, I hope this is alright for you.

It appears in 1.16-pre1 (as stated in the previous comments) the bug was fixed completely, however since this report was not resolved as "Fixed" by a Mojang developer the fix might have happened accidentially due to the anger logic rewrite. I have therefore reopened this report. Though normally when there was indeed an intended fix attempt by a developer we prefer to create a new report instead.

user-189af 2020-08-30T17:17:45Z

Oh, okay.

user-189af 2020-08-30T20:08:29Z

I actually found out this happens with more than just zombified piglins... Maybe time to create a new report...

marcono1234 2020-08-30T22:38:58Z

Yes please create a separate report then (and refer to this one). Additionally if it turns out that for these mobs the bug was fixed / did not exist in 1.16-pre1, but started appearing in a newer version then we will likely resolve this report here and only keep your report open instead.

user-189af 2020-09-04T19:57:42Z

@@unknown → MC-199589

marcono1234 2020-09-05T21:26:40Z

Thanks @unknown. I have reverted some of the changes I made to this report and resolve it as "Fixed" again because the issue was indeed fixed in 1.16-pre1.
The new report is MC-199589 which covers all kind of mobs which are passive by default (or don't attack the player because they are invisible) and are now affected by this bug.

Zombified piglins get angry when hit in creative mode

The bug

Reproduction steps

Code analysis

Linked issues

is cloned by 1

is duplicated by 1

relates to 1

Attachments

Comments 18