mojira.dev
MC-7196

Nether cave/tunnel generator produces incorrect/cut tunnels

The tunnels/caves in Nether can have unnatural looking straight cuts/walls at chunk borders. The reason is an old bug that has been fixed from the overworld cave generator, but not from the Nether one. Such tunnels are easiest to find by using a mapper (due to the difficulty of moving in Nether, low visibility, and of course because tunnels/caves are usually more or less buried inside solid stuff).

Examples of buggy tunnels
See map screenshots; the straight edges of the tunnels are not due to mapping program, but simply because the tunnels have cuts in them, at chunk borders.

Possibly reproducible with world seed -807116175 (with defaults), location x:142, y:98, z:-83 in Nether (place of screenshot cut_tunnel_3 and ...02.24.27). The location is actually two tunnels, both cut at the same place, but just cut on different directions. (The other map screenshots are of the same world, locations are about #1: 187,99,135 and #2 131,94,260 + 60,85,235.)

The bug
Compare classes MapGenCaves and MapGenCavesHell. The overworld version (MapGenCaves) transfers a random generator seed-parameter in the methods, while the Nether-version does not. Due to this, for the Nether version the map generator's one common random number generator gets to different states at different chunks for the generation of the supposedly same tunnel/cave. The different states of course lead to different random shapes of the tunnel.

The fix
Adapt the use of the seed parameter from the MapGenCaves class to MapGenCavesHell class. (I will not show the code here, as the changes are quite spread and are trivial.)

Related issues

Attachments

Comments

migrated
[media][media][media][media]
bugi74

Still valid for 13w09b, and even if there is new stuff in Nether, the example seed and location still works.

Jens Bergensten

Fixed as suggested.

Josh74000MC

this bug used to happen on beta 1.7.3, but got fixed in beta 1.8 which is good as it got annoying.

bugi74

Jens Bergensten

Plausible

cave, nether, tunnel, world-generation

Minecraft 1.4.6, Minecraft 1.4.7, Snapshot 13w09b

Snapshot 13w09c

Retrieved