mojira.dev
MC-73611

Ambient occlusion is not working right

Ambient occlusion in model files treats every cuboid/element as if it goes from model coordinates 0,0,0 to 16,16,16 of the block it is rendered as a part of. This causes massive visual artifacts when they aren't actually in that situation. Occurs on both fast and fancy. Only when ambient occlusion ('smooth lighting' in video settings) is turned on (fast or fancy both work)

The bed screenshot uses a custom model file so that both visual halves of the bed are actually rendered as part of the head end (shown covered with stone) of the bed. The fence gate uses the vanilla built-in model file, there is no resource pack selected.

Steps to reproduce (hooray, finally included this in one of my reports):
1. Set brightness to moody
2. Turn on smooth lighting
3. Construct the arrangement shown in the picture (the block to the side of the lower gate just casts an ambient occlusion shadow, which makes the effect visible)
4. Compare the middle top part of the fence gates

This effect can also be seen with flower pots after enabling ambient occlusion in the model files.

Attachments

Comments

migrated
[media][media]
migrated

Really? Nobody cares?

marcono1234

I don't really understand that, but I can confirm that the gate is maybe too dark (in 1.8.1-pre4) and that the attachment on the sides aren't affected from above

kumasasa

Is this still an issue in the current Minecraft Snapshot 15w45b or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

migrated

Forgot about this issue. It seems it was fixed somewhere along the line. It may have even been a feature listed in a changelog.

migrated

Note to anyone finding this:
Elements within the space of the block (model coords 0,0,0 to 16,16,16) seem to take their lighting from the correct place now, but any elements extending outside the space of the block (model coordinate below 0 / above 16) are likely to have minor problems.

migrated

(Unassigned)

Unconfirmed

Minecraft 1.8.1-pre3

Minecraft 1.10.2

Retrieved