Villages generate underwater improperly

Just out of interest, since villages have currently only support for biomes "plains" and "desert", what would be your idea on "properly generated" village in ocean biome?

Imho, the bug here is that the village is generated in the first place.

For some reason, when using the flat world gen, it's counted as being "plains".
Thanks for pointing this out though 😉

biome_1 (in the presets) sets it to a plains biome, so this works as intended.

That is because the biome is that plains, as it is set with the single biome ID code (the "1").
("biome_1", according to wiki, enables temples and such, but since the biome is plains, no such features should appear).

The biome here is just forcefully covered with water (defined with the rest of the preset string). The village generation code isn't smart enough and trusts that the terrain generator would have produced valid terrain for the biome.

For example, there are also normal world seeds where villages are generated in one block deep water; the biome is correct and the generator just forgets to double check for wet feet.

Duplicate of MC-2206.

I created a new world, with the following preset: 2;7,5x1,5x3,5x12,90x9;1;biome_0,village

Now, that definitely should be ocean, right?
WRONG! It's plains again - everything is counted as plains when making a flat world.

Okay, I decided to try again, using this preset: 2;7,5x1,5x3,5x12,48x9;1;village,biome_21
And the same seed as original: -5009994271433305898

Now biome_21 should theoretically be Jungle (assuming it maps with biome ID numbers)
Well the village still generated. Not only that but I saw bats 'flying' underwater.

Link to save: http://www.mediafire.com/?cngfda34i75q1lf

Read my comment more thoroughly (or even better, the related wiki page) - the biome is not set with the "biome_1" part, but with the single "1".

x;xxxx;1;biome_xxxx
See the 1 there?
The "biome_1" is better understood as "enable biome-specific features of type 1".

So instead, simply drop the "village" part away (as they shouldn't be there anyway). And you can drop the "biome_1", too, as they won't generate anything in plains (or underwater) either.

Thanks for explaining this - still I think there are issues here that need to be addressed.