[MC-83003] Barrier particle not visible if barrier block is in offhand

The bug

While holding a barrier block in the offhand you will not see the particle effect in placed barrier blocks.

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is cloned by 1

MC-221824 Barrier/light particles are not visible if barrier/light item is in offhand Open

is duplicated by 18

MC-85767 Barrier particles not shown when barrier is in off hand Resolved

MC-86329 Barrier in off-hand won't show barrier particles Resolved

MC-87011 When Barrier In Offhand Slot Barriers Stay Invisible Resolved

MC-87609 Barrier particles doesn't show up when barrier is held in off-hand Resolved

MC-87815 Barriers in second hand do not trigger the particle Resolved

13 more links

Attachments

Comments 43

Christoforos Charalambous 2015-09-01T17:07:05Z

Confirmed

[Mod]Les3awe 2015-10-07T12:43:59Z

Confirmed for 15w40b

tomudding 2015-10-07T14:13:16Z

Confirmed for 15w41a

[Mod]Les3awe 2015-10-07T14:54:30Z

Confirmed for 15w41b

[Mod]Les3awe 2015-10-15T11:29:46Z

Confirmed for 15w42a

33 more comments

[Mod]Les3awe 2015-10-22T10:32:34Z

Confirmed for 15w43a

[Mod]Les3awe 2015-10-29T11:46:21Z

Confirmed for 15w44a

SupahYayaz 2015-11-07T12:40:46Z

Confirmed snapshot 15w45a

[Mod]Les3awe 2015-11-12T15:11:56Z

Confirmed for 15w46a

42Richtofen42 2015-11-22T19:46:43Z

Confirmed for 15w47c

Ely G 2015-12-11T05:27:19Z

confirmed for 15w49a, 15w49b, and 15w50a. It affects the primary hand as well.

James (inactive) 2015-12-22T03:14:28Z

Confirmed for 15w51b. Affects offhand; does not affect main hand.

Étienne B. 2015-12-29T00:46:56Z

Strange enough, the bug happens also in the main hand. Well, at least for me.

user-f2760 2015-12-29T00:50:29Z

@unknown turn particles on in the video settings

Étienne B. 2015-12-29T01:28:19Z

O.O

...I never existed... ...You saw nothing at all...

James (inactive) 2016-01-13T23:11:18Z

Confirmed for 16w02a.

19Spleen 2016-02-28T13:26:04Z

Confirmed for 1.9-pre4

marcono1234 2016-03-07T11:40:37Z

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

The reason why this is happening is because the net.minecraft.client.multiplayer.WorldClient.doVoidFogParticles(int, int, int) method only tests if the player holds a barrier block in his mainhand.

public void doVoidFogParticles(int posX, int posY, int posZ)
{
    int i = 32;
    Random random = new Random();
    // Replaced this
//ItemStack itemstack = this.mc.thePlayer.getHeldItemMainhand();
//boolean flag = this.mc.playerController.getCurrentGameType() == WorldSettings.GameType.CREATIVE && itemstack != null && Block.getBlockFromItem(itemstack.getItem()) == Blocks.barrier;
    ItemStack itemStackMainhand = this.mc.thePlayer.getHeldItemMainhand();
    ItemStack itemStackOffhand = this.mc.thePlayer.getHeldItemOffhand();
    boolean flag = this.mc.playerController.getCurrentGameType() == WorldSettings.GameType.CREATIVE && (
            (itemStackMainhand != null && Block.getBlockFromItem(itemStackMainhand.getItem()) == Blocks.barrier) || 
            (itemStackOffhand != null && Block.getBlockFromItem(itemStackOffhand.getItem()) == Blocks.barrier));
    
    BlockPos.MutableBlockPos blockpos$mutableblockpos = new BlockPos.MutableBlockPos();

    for (int j = 0; j < 667; ++j)
    {
        this.func_184153_a(posX, posY, posZ, 16, random, flag, blockpos$mutableblockpos);
        this.func_184153_a(posX, posY, posZ, 32, random, flag, blockpos$mutableblockpos);
    }
}