mojira.dev
MC-84783

Damaged Tag for resource packs is semi broken 1.9

MC-58445
Torabi states:
that /give @p stick 1 1 works as intended and in 1.9 we will be able to define custom textures for item based of damage.

"overrides": [
        {
            "predicate": {
                "damaged": 1
                "damage": 0.5
            },
            "model": "item/example"
        }

that is the code for defining it, however on delving into this i quickly discovered that it only works on 'damageable item' so a sword for instance will work, however a stick or any other item will not.

I believe the reason for this is that damage can only be expressed as a decimal (percentage of an items entire durability)

I propose instead use the tags or similar

"damage_min": 1
    "damage_max": 10

hence damage would be with in a range so that its not just limited to tools

reason it needs to change: Custom Maps enough said

Also it would be better if we had access to all tags items can have example: Name a golden axe Ban Hammer then it would gain a cool new texture (although i would probably put it i the lore not the name)

Linked issues

Attachments

Comments

[Mod] redstonehelper

Invalid, this is a feature request.

Alpha

Just because I also proposed a solution doesn't make this a feature request, if anything it makes the bug report that much more helpful
Something is a bug if you can prove that is doesn't work as intended, as per MC-58445 Mod Torabi, states that the extra data values on Items were intended.
As such I DEMAND that u reopen one of these bugs because either way the no item texture should not exist, either way it is a bug

[Mod] redstonehelper

Then it's working as intended. See here:

"Any item that can take damage gets: damaged & damage"

Alpha

Does that mean Torabi was wrong?

[Mod] redstonehelper

Just because extra data values exist on some items doesn't mean a separate feature meant for damagable items must apply to them as well.

edit: Seems like Grum confirmed it on Twitter again: https://twitter.com/_grum/status/628058688683646976

Alpha

Yes but say Torabi was right and they do make it so u can retexture out of bounds 'Damage value' items would that make the current tags irrelevant.

[Mod] redstonehelper

This is a bug tracker, not a place for hypothetical features.

Torabi

You have wildly misinterpreted my comment on MC-58445. It was never intended for you to be able to define textures for "unused" or "out of bounds" damage values. That the game even attempted to treat them as valid items was a bug. The feature @unknown is currently adding to resource packs is only intended to allow you to customize currently existing states for currently existing blocks and items, not define new ones. That would be part of the plugin API, which has not been implemented yet. I'm sorry for any confusion.

Alpha

(Unassigned)

Unconfirmed

Minecraft 15w31c

Retrieved