[MC-89365] Custom Potions are Broken

I have noticed that when making a custom potion, the custom effects don't override the potion's default effect. E.g., when I use the command below, I get a potion that has invisibility as well as blindness, but as I customized it, it should only have blindness.
Here's the command:

/give @p minecraft:splash_potion 1 0 {CustomPotionEffects:[{Id:15,Amplifier:0,Duration:200}],Potion:"minecraft:invisibility"}

If you think I'm doing it wrong, you're wrong. If you didn't know, they changed the potion item's format. I double checked, and looked at an item entity's NBT, and I'm right.

To test it, put the above command into a command block, and power it.
If you want to give yourself a custom water bottle, fine! However, you're also supposed to have the possibility of picking the color. A water bottle is just blue. For example, I thought gray would look good for a blindness potion. Thusly, I used an invisibility potion as base, and the custom effects should have overridden the base effect.

Linked issues

duplicates 1

MC-89312 Custom Potion effects don't override Potion tag Resolved

Attachments

Comments 24

[Mod] redstonehelper 2015-09-23T21:35:59Z

Don't.

Logical_Cyclops 2015-09-23T21:37:48Z

Again man! Your doing it
wrong, haven't you tried
the correct method?
because remaking a issue
that has been already resolved
shows you clear haven't

Correct Way:

{CustomPotionEffects:[{Id:15,Amplifier:0,Duration:200}]}

Please try it this time.

Don't assume this
isn't the right way as I tested
this. If you need me to show video
proof I can. Also I've been using
command blocks for months, so I
know my stuff, please believe me.

Sam Tooch 2015-09-23T21:44:11Z

BUT THEN ITS JUST A WATER BOTTLE! THATS NOT HOW CUSTOM POTIONS WORK! I KNOW CUZ IVE WORKED WITH THEM BEFORE!

Logical_Cyclops 2015-09-23T21:46:26Z

I've posted video proof
showing the correct way.

(see attachments).

Sam Tooch 2015-09-23T21:48:31Z

guess what? I tried it. its a water bottle. is that how custom potions work? no. it isn't. why? because custom potions don't hafta be a water bottle. they're s'posed to have the possibility of not looking like a water bottle.

14 more comments

Logical_Cyclops 2015-09-23T21:53:33Z

If your complaining
about't being named
a water bottle than
just do:

/give @p minecraft:splash_potion 1 0 {CustomPotionEffects:[{Id:15,Amplifier:0,Duration:200}],display:{Name:"DesiredName"}}

If you are just getting the water bottle it's
self than you are being very ignorant
or likely that you are not even following the
correct way. I'm trying to help you out
with this.

Sam Tooch 2015-09-23T21:56:58Z

It's not about names. If you noticed, the command gives you a named potion. It's about the potion itself. It's not supposed to give you just a water bottle. Now I thought gray would be an appropriate color for a blindness potion. You're supposed to be able to pick the color, without the default potion effects. I know what I'm talking about.

Logical_Cyclops 2015-09-23T22:00:40Z

So your either saying that
your having an issue picking
the color. or when throwning
the potion it looks like a
water bottle?

Sam Tooch 2015-09-23T22:08:46Z

no. look at the potion color in your hand and in the air. is it the color of an invis pot? no. its blue. cuz its water. now the CustomPotionEffects tag says "this potion has a blindness 1 effect for 10 seconds. now this overrides the default effect."

Sam Tooch 2015-09-23T22:12:35Z

Because its a CUSTOM potion, and ive worked with them in 1.8

[Mod] redstonehelper 2015-09-23T22:15:19Z

Thank you both for remaining civil.

Here's what's happening:

1.8:

Potion name is determined by the first custom potion effect or the item id if no custom effects are provided
Potion effects (id, amplifier, duration) are determined by the custom potion effects or the item id if no custom effects are provided
Potion color is determined by the item id

1.9:

Potion name is determined by the Potion tag (or lack thereof)
Potion effects (id, amplifier, duration) are determined by the Potion tag and custom potion effects
Potion color is determined by all the effects

Sam Tooch: If I understand you correctly, your issue is that firstly, when custom potion effects are provided the default potion effect is still applied and secondly, the potion color is influenced by custom potion effects as well. The potion color being a mix of all effects' colors is working as intended (no vanilla potion has multiple effects so this feature was clearly added with custom potion effects in mind), but the default potion effect being applied regardless off whether custom potion effects are provided is different from 1.8. It might be intended since now there's the Potion tag which uniquely identifies potion effect, amplifier and duration as opposed to a magic number, it might be a bug since it's different from before.

Is this your issue? In that case we can reopen the original ticket.

Sam Tooch 2015-09-23T22:18:46Z

Now I've argued for a half hour. I now intend to let a moderator decide, and I'll be back in a couple hours. Cya!

Logical_Cyclops 2015-09-23T22:24:14Z

I've found a way to specify the color
by doing this:

/give @p minecraft:splash_potion 1 0 {CustomPotionEffects:[{Id:14,Amplifier:0,Duration:0},{Id:15,Amplifier:0,Duration:200}],HideFlags:32}

[Breaking it Down]:

the first custom effect
which will be the color, you
want to have the duration set
to 0 so you won't get invisibility.
Then the second one is your desired effects,
make sure to include hide flags
to hide the effects in the lore.
If you want it displayed then
I'm sorry but I couldn't figure
any other way besides this.
Though this can be a good
workaround 😉

I hope this helps!

Sam Tooch 2015-09-23T22:31:33Z

MC-84019

[Mod] redstonehelper 2015-09-23T22:33:35Z

Brian: This still mixes the colors of effects 14 and 15. You can use constructs like this (with fire resistance as an example) to get close to the desired color, but it's clearly not perfect:

/give @p minecraft:splash_potion 1 0 {CustomPotionEffects:[
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:10,Amplifier:0,Duration:0},
{Id:15,Amplifier:0,Duration:200}
],HideFlags:32}

Sam: That issue is a duplicate of a fixed issue.

Logical_Cyclops 2015-09-23T22:38:42Z

Well, then, looks like it's
a bug after all. Hopefully
mojang can fix it. For now
sam, you need to use a work around
method that redstonehelper
showed above.

Torabi 2015-09-23T22:47:59Z

@unknown, please stop inserting random line breaks in your comments. It bloats the page, and is awkward for others to read.

Sam Tooch 2015-09-24T01:13:24Z

Redstone, I respect your judgement, and stand corrected. I'm happy a mod decided. I never noticed the potion color, probably cuz of the glint. Can you delete this embarrassment, though?

Sam Tooch 2015-09-24T01:16:49Z

Oh, and I found a graphical glitch while testing this.

[Mod] redstonehelper 2015-09-24T01:34:28Z

Please file a new ticket for the graphical glitch you found. No need to delete this ticket.

Sam Tooch 2015-09-24T01:42:45Z

Ha. Ha. Ha. Very funny.

Sam Tooch 2015-09-24T01:43:32Z

don't wanna dupe the graphical glitch

[Mod] redstonehelper 2015-09-24T01:44:29Z

If it's been reported already you shouldn't make a new ticket, but you don't need to be afraid of duplicating tickets if you just make an effort to search before creating new tickets.

Sam Tooch 2015-09-24T01:53:07Z

Stop commenting! My inbox isn't unused!