[MC-93826] Breeding hearts only show once and not all the time an animal can breed anymore

The bug

In 1.8.8 and maybe later animals which can breed showed hearts the whole time they were able to breed.

Now the hearts are only shown once.

The reason

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

The reason why this happens is because the client never receives the InLove value from the server. In 1.8.9 and earlier the method net.minecraft.entity.EntityAgeable.getGrowingAge() (MCP 9.10) returned for the client the stored value whether or not the animal is a child (for 1.8 entry 12 of the data watcher, for 1.9 net.minecraft.entity.EntityAgeable.field_184751_bv). In 1.9 it returns -1 if the animal is a child, 1 if it is not. This breaks some logic for the net.minecraft.entity.passive.EntityAnimal class.

Besides that the client should receive the InLove value because neither in 1.8.9 nor in the latest versions summoning an animal with InLove greater than 0 shows particles.

/summon pig ~ ~ ~ {InLove:2147483647}

Note: The server should not run the particle spawning code of the method net.minecraft.entity.passive.EntityAnimal.onLivingUpdate().

Related issues

is duplicated by

MC-87940 Breeding Bug

MC-141027 Love particles not appearing when two animals are in "Love Mode" when breeding

MC-295808 Animals display heart particles only once when breeding

relates to

MC-88230 When feeding a tamed horse or llama with a golden apple/carrot or hay bale, the cursor moves to the right

MC-99597 Not needed spawnParticles calls of the server

MC-172144 Hoglin breeding is broken

MC-208727 Axolotls seem to freeze while breeding

Attachments

Breeding hearts (1.8.8).mp4

Breeding hearts (15w49b).mp4

Comments

migrated 2015-12-04T18:49:13Z

[media][media]

Fusseel 2016-03-11T16:47:15Z

Issue still exists up to latest version, Minecraft 1.9.1-pre3.

Fusseel 2016-03-12T09:26:17Z

I do not quiet understand the reason that was given by Marcono1234. It was working in 1.8 and prior versions, why does it only occur since the 1.9 snapshots? Clients are using an internal server since 1.3, so the issue should have appeared back then already, but it did not. So why now in 1.9?

marcono1234 2016-03-12T14:24:32Z

You are right, I kind of messed up yesterday. The reason seems to be that the client does not receive the InLove value anymore, because in 1.8 the client had the correct InLove value, in 1.9 it does not. I will update the report in a moment.

Fusseel 2016-04-13T08:13:13Z

Still not fixed in 16w15a.

Fusseel 2016-04-28T07:19:55Z

Still present in 1.9.3-pre2.

migrated 2016-05-30T19:55:25Z

Present in 1.9.4 & 16w21b

Also might want to add MC-88230 as a related ticket.

tryashtar 2016-10-21T02:48:32Z

Still here up through 16w42a.

migrated 2016-11-01T21:15:13Z

Exists in 16w43a

Fusseel 2017-07-31T09:34:31Z

1.12 is affected

Fusseel 2018-07-23T14:23:07Z

Still an issue in 1.13.

muzikbike 2018-11-26T09:02:27Z

Reproduced in 1.13.2

TheBoy358 2019-02-12T18:26:51Z

Confirmed in 19w04b, 19w05a and 19w06a.

Fusseel 2019-04-07T19:13:51Z

Confirmed for 19w14b. Really hoping this is fixed soon since a lot of related bugs were taken care of very recently.

TheBoy358 2019-09-18T15:32:48Z

Confirmed in 19w38b.

TheBoy358 2019-11-07T19:12:19Z

Confirmed in 19w45a.

TheBoy358 2019-11-08T15:20:48Z

Confirmed in 19w45b.

TheBoy358 2019-11-15T12:19:54Z

Confirmed in 19w46b.

migrated 2020-01-27T22:51:11Z

Confirmed 1.15.2 FIX THIS BUG please

Orbic 2020-02-28T00:19:03Z

Still in 20w09a

numeritos 2020-06-21T00:11:46Z

Affects 1.16-rc1

Avoma 2021-01-04T18:00:31Z

Can confirm in 20w51a.

Avoma 2021-01-24T12:03:29Z

Can confirm in 21w03a.

Avoma 2021-02-04T14:33:54Z

Can confirm in 21w05a.

migrated 2021-05-28T18:15:12Z

Affects 1.17 Pre-release 1

Orbic 2021-06-08T19:33:51Z

In 1.17

ampolive 2021-07-08T19:26:57Z

Can confirm in 1.17.1.

Orbic 2021-11-11T18:13:42Z

Can confirm for 1.18 Pre-1

Orbic 2022-02-02T21:16:12Z

In 22w05a, actually was quite annoying in experience of trying to breed a blue Axolotl

Orbic 2022-05-22T19:10:19Z

In 1.19 Pre-1

Orbic 2022-05-24T18:54:26Z

Can confirm for 1.19 Pre-2

Orbic 2022-05-26T01:07:54Z

Affects 1.19 Pre-3

Orbic 2022-05-30T19:11:14Z

In 1.19 Pre-4

Orbic 2022-06-02T04:00:08Z

In 1.19 Pre-5

Jeuv 2022-10-01T01:17:56Z

Still in 1,19.2.

Orbic 2022-11-05T23:12:08Z

In 22w44a

Orbic 2022-11-16T18:57:09Z

Can confirm for 22w46a

muzikbike 2023-09-18T13:53:04Z

Can confirm in the 1.20.2 release candidate.

BeeTeeKay 2024-05-13T03:26:44Z

Can confirm in 24w19b and release 1.20.6

BeeTeeKay 2024-06-26T05:39:03Z

Affects 1.21

insane96mcp 2025-02-08T11:16:11Z

This is easily fixed

Using Mojmaps 1.20.1
In the aiStep method the code calls the addParticles method but as pointed out by other users the inLove ticks aren't sent client side.

if (this.inLove > 0) {
  --this.inLove;
  if (this.inLove % 10 == 0) {
      double d0 = this.random.nextGaussian() * 0.02D;
      double d1 = this.random.nextGaussian() * 0.02D;
      double d2 = this.random.nextGaussian() * 0.02D;
      this.level().addParticle(ParticleTypes.HEART, this.getRandomX(1.0D), this.getRandomY() + 0.5D, this.getRandomZ(1.0D), d0, d1, d2);
  }
}

This can be fixed by checking if the code is running server side and then send the particles to clients

if (this.inLove > 0) {
  --this.inLove;
  if (this.inLove % 10 == 0) {
    double d0 = this.random.nextGaussian() * 0.02D;
    double d1 = this.random.nextGaussian() * 0.02D;
    double d2 = this.random.nextGaussian() * 0.02D;
    //Note, I didn't use the speed calculated above
    if (this.level instanceof ServerLevel serverLevel)
      serverLevel.sendParticles(ParticleTypes.HEART, this.getRandomX(1.0D), this.getRandomY() + 0.5D, this.getRandomZ(1.0D), 1, 0, 0.1f);
  }
}

Duffy Springpat 2025-05-31T04:34:12Z

Still in 1.21.5 and 1.21.6 snapshots.