mojira.dev
MC-98160

Boat not being destroyed from fall damage

The Bug

Boats are not destroyed when falling from high distances.

Steps to Reproduce

  • Summon a boat high above yourself.

/summon minecraft:boat ~ ~30 ~3
  • Wait for it to reach the ground.

  • → ❌  Notice how boats are not destroyed when falling from high distances.

Expected Behavior

The expected behavior would be that boats are destroyed when falling from high distances.


Code analysis by @unknown can be found in this comment.

Attachments

Comments

migrated
[media][media][media][media]
marcono1234

Please change the summary to something like "Boat not being destroyed from fall damage" or something similar to make it clear that it is about the boat

marcono1234

Please link to this comment in the description

The following is based on a decompiled version of Minecraft 1.10 using MCP 9.30.

It looks like the reason for this is that the method net.minecraft.entity.item.EntityBoat.getBoatGlide() and probably all the other methods working the same are not detecting the ground below the boat in the tick its OnGround field is set to true. Besides that the method net.minecraft.entity.item.EntityBoat.updateFallState(double, boolean, IBlockState, BlockPos) tests in theory the same condition twice. What it does is that if the boat is on ground, but its status is not ON_LAND it cancels all fall damage. If the getBoatGlide() method worked correctly this should probably never happen, or at least I can't think of any situation right now where this could happen.

If this bug is fixed, MC-105103 will probably work correctly as well.

migrated

The boat does get destroyed from fall damage if you /entitydata the motion upwards and then when It hits the ground, it breaks and also makes the rider take fall damage.

migrated

Confirmed in 17w45a

migrated

Affects 1.13-pre4

migrated

Affects 1.13-pre8

Asteraoth

Confirmed for 1.13

Asteraoth

Confirmed for 18w30b

Asteraoth

Confirmed for 18w31a

Asteraoth

Confirmed for 18w32a

Asteraoth

Confirmed for 18w33a

Asteraoth

Confirmed for 1.13.1-pre1

migrated

Related: MC-119369  - boats do break into planks and sticks, but only dropped from particular, very specific heights: 12.5, 13.5, 49.5, 51.5, 111.5, 114.5, 198.5 or 202.5 blocks.

Also, confirmed 1.16.3

Avoma

Can confirm in 20w48a.

Avoma

Can confirm in 21w03a.

Avoma

Can confirm in 21w05a.

Avoma

Can confirm in 21w05b.

Avoma

Can confirm in 21w06a.

Avoma

Video attached.

Avoma

Can confirm in 21w07a.

Avoma

Can confirm in 21w11a.

Avoma

Can confirm in 21w13a.

Avoma

Can confirm in 21w15a.

Avoma

Can confirm in 21w17a.

migrated

Can confirm in 21w20a.

Avoma

Can confirm in 1.17.

ampolive

Can confirm in 1.17.1.

migrated

This is in direct contradiction with MC-119369, yet both are confirmed for the same versions... which report is lying about the breakability?
EDIT: Ah, wait, I see now after reading comments on that. In that case, this report should clarify it is on mosy y coordinates, but not all.

Avoma

I am able to confirm this behavior in 21w38a. Here are some extra details regarding this problem.

The Bug:

Boats are not destroyed when falling from high distances.

Steps to Reproduce:

  • Summon a boat high above yourself.

/summon minecraft:boat ~ ~30 ~3
  • Wait for it to reach the ground.

  • → ❌  Notice how boats are not destroyed when falling from high distances.

Expected Behavior:

The expected behavior would be that boats are destroyed when falling from high distances.

[Mod]Les3awe

(Unassigned)

Confirmed

Collision, Entities

boat, fall-damage

Minecraft 1.9 Pre-Release 4, Minecraft 1.9, Minecraft 1.9.1 Pre-Release 1, Minecraft 1.9.1 Pre-Release 2, Minecraft 1.9.1 Pre-Release 3, ..., 1.17.1, 21w37a, 21w38a, 21w40a, 21w43a

Retrieved