mojira.dev
MCPE-111894

Fireworks does not have far away blast sound and far away twinkling

If you listen carefully, you will notice it does not have far away blast sound, it only has the one when you're close to it, and also it does not have twinkling sound when it's far away.

Linked issues

Attachments

Comments

GoldenHelmet

All of the firework sounds are coded in the vanilla behavior pack to use default range and attenuation, which means they can only be heard from 16 blocks away. They are also fairly quiet even up close--quieter than a bell, for instance.

Expected behavior would be for the large ball firework explosions to be heard at 1/10th the distance of lightning. Therefore, the firework.large_blast should have a volume of 100.0 in sounds.json, and possibly a min_distance of 10.0 in sound_definitions.json (lightning uses 1000.0 and 100.0, respectively). The smaller ball explosion and the twinkle sound perhaps should use lower values. The large blast should probably also get a volume increase in sound_definitions because it is currently softer than the small blast.

While experimenting with these settings I noticed that firework sounds also have a very large hard-coded random variation in volume. It is hard to understand why this variation exists unless it was meant to correlate with the random fuse timer in a context of minimal attenuation (i.e. a large min_distance in sound_definitions, like lightning has and ghasts used to have before the fix to MCPE-35222). However, not only do fireworks lack any min_distance setting, linking the actual volume to flight time would only make sense in open air. If you launch fireworks under a low ceiling this is just broken. Fireworks exploding right in your face can randomly make no sound at all.

migrated

(Unassigned)

579156

Confirmed

Multiple

vanilla-parity

1.16.220.52 Beta, 1.16.220.50 Beta, 1.16.210.60 Beta, 1.16.210.59 Beta, 1.16.210.58 Beta, ..., 1.16.210.54 Beta, 1.16.210.53 Beta, 1.16.201 Hotfix, 1.16.210, 1.20.0

Retrieved