[MC-10366] Renamed minecarts still drop a minecart item in creative mode

The bug

Renamed minecarts still drop a minecart item in creative mode. Expected behavior would be not to drop a minecart.

How to reproduce

Rename a minecart
Punch it
→ ❌ It still drops its item on creative

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

Attachments

Comments 33

kumasasa 2013-02-26T22:41:30Z

Confirmed.

julian mazer 2013-02-26T23:09:59Z

This Happens To all minecarts

Roadsguy 2014-03-11T00:08:06Z

I would think this is a good feature if the minecart keeps its name data when placed, and drops itself as a named item when you break it, but if not, then it's got to be a bug.

marcono1234 2014-05-31T16:02:09Z

Confirmed for 14w21b

Unnamed minecarts with command blocks don't drop something

PancakeMan77 2015-08-26T00:12:10Z

Can someone update the title to include creative? It's confusing otherwise. If you were in survival, it would make sense. I know that you are in creative, but it was initially confusing.

23 more comments

[Mod] redstonehelper 2015-08-26T00:30:38Z

Done, thanks.

PancakeMan77 2015-08-28T15:25:16Z

Confirmed for 15w35c. I also want to note, that when done with a minecart command block, it will drop a minecart named "@".

Anon Ymus 2015-08-28T15:43:29Z

That's MC-41893.

[Mod] redstonehelper 2015-08-28T15:47:30Z

I resolved MC-41893 as a duplicate of this ticket since they're the same (command block minecarts are named minecarts too!).

Steven W.d.V. 2015-09-23T15:20:47Z

Confirmed for 15w39c

Steven W.d.V. 2015-09-30T16:26:44Z

Confirmed in 15w40b

Steven W.d.V. 2015-10-07T15:06:34Z

Still present in 15w41b

Steven W.d.V. 2015-10-14T15:25:24Z

Confirmed for 15w42a

Steven W.d.V. 2015-10-22T15:47:44Z

Confirmed for 15w43b and 15w43c

Steven W.d.V. 2015-10-28T17:18:09Z

Confirmed for 15w44a and 15w44b

Steven W.d.V. 2015-11-05T19:26:21Z

Confirmed for 15w45a

Steven W.d.V. 2015-11-18T19:59:16Z

Confirmed for 15w47a and 15w47c

Steven W.d.V. 2015-12-20T14:08:56Z

Confirmed for 15w51b

Steven W.d.V. 2016-02-05T16:46:35Z

Confirmed for 16w05b

Immaterialise 2016-02-17T20:37:57Z

Confirmed for 1.9-pre1

marcono1234 2016-02-17T21:19:05Z

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.

This behaviour could be changed by modifying the public boolean attackEntityFrom(DamageSource source, float amount) method of the net.minecraft.entity.item.EntityMinecart class. However as this is done on purpose this bug might be "Works as Intended".

/**
* Called when the entity is attacked.
*/
public boolean attackEntityFrom(DamageSource source, float amount)
{
if (!this.worldObj.isRemote && !this.isDead)
{
    if (this.func_180431_b(source))
    {
        return false;
    }
    else
    {
        this.setRollingDirection(-this.getRollingDirection());
        this.setRollingAmplitude(10);
        this.setBeenAttacked();
        this.setDamage(this.getDamage() + amount * 10.0F);
        boolean var3 = source.getEntity() instanceof EntityPlayer && ((EntityPlayer)source.getEntity()).capabilities.isCreativeMode;

        if (var3 || this.getDamage() > 40.0F)
        {
            if (this.riddenByEntity != null)
            {
                this.riddenByEntity.mountEntity((Entity)null);
            }
            
            // Changed this
            //if (var3 && !this.hasCustomName())
            if (var3)
            {
                this.setDead();
            }
            else
            {
                this.killMinecart(source);
            }
        }

        return true;
    }
}
else
{
    return true;
}