Server side particle spawning does not create particles for client

Confirmed for

• 16w06a

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.

The reason for this seems to be that the methods spawning the Snowman, VillagerGolem and WitherBoss (yes, a WitherBoss should – based on the code – also create particles) are only called server side, however the methods they are calling to create the particles are client side. This is a little bit complicated because they are calling the method for all net.minecraft.world.IWorldAccess. While for the client the net.minecraft.client.renderer.RenderGlobal (which creates the particles) is in this list, for the server only net.minecraft.world.WorldManager are in this list. The problem is their method for creating particles is simply doing nothing. This bug would be more obvious if there would be base, client and server classes for entities, blocks... and if the particle spawning method of the net.minecraft.client.renderer.RenderGlobal would be directly called.

Anyways to solve this problem the method sending the particles packet to the client should be called: public void func_175739_a(EnumParticleTypes p_175739_1_, double p_175739_2_, double p_175739_4_, double p_175739_6_, int p_175739_8_, double p_175739_9_, double p_175739_11_, double p_175739_13_, double p_175739_15_, int ... p_175739_17_) of the net.minecraft.world.WorldServer class

How to fix the bug

Instead of having the for loops to create the particles, the following could / should be used:

Snowman

• Affected class: net.minecraft.block.BlockPumpkin

• Affected method: private void createGolem(World worldIn, BlockPos p_180673_2_)

• New code:
  var11 - The BlockPos at which the Snowman gets created
  var9 - The Snowman

  ((WorldServer) worldIn).func_175739_a(EnumParticleTypes.SNOW_SHOVEL, (double)var11.getX() + 0.5D, (double)var11.getY() + var9.height / 2, (double)var11.getZ() + 0.5D, 120, var9.width / 4, var9.height / 4, var9.width / 4, 0D, new int[0]);

VillagerGolem

• Affected class: net.minecraft.block.BlockPumpkin

• Affected method: private void createGolem(World worldIn, BlockPos p_180673_2_)

• New code:
  var10 - The BlockPos at which the VillagerGolem gets created
  var13 - The VillagerGolem

  ((WorldServer) worldIn).func_175739_a(EnumParticleTypes.SNOWBALL, (double)var10.getX() + 0.5D, (double)var10.getY() + var13.height / 2, (double)var10.getZ() + 0.5D, 120, var13.width / 4, var13.height / 4, var13.width / 4, 0D, new int[0]);

WitherBoss

• Affected class: net.minecraft.block.BlockSkull

• Affected method: public void func_180679_a(World worldIn, BlockPos p_180679_2_, TileEntitySkull p_180679_3_)

• New code:
  var12 - The BlockPos at which the WitherBoss gets created
  var14 - The WitherBoss

  ((WorldServer) worldIn).func_175739_a(EnumParticleTypes.SNOWBALL, (double)var12.getX() + 0.5D, (double)var12.getY() + var14.height / 2, (double)var12.getZ() + 0.5D, 120, var14.width / 4, var14.height / 4, var14.width / 4, 0D, new int[0]);

Note: In my opinion the particles should also be adjusted, so the VillagerGolem creates iron block breaking particles and the WitherBoss soul sand breaking particles.

Reporter seems inactive.
Recommendation Mod giving ticket to Marcono1234.