[MC-6654] Water/Lava Colliding no longer gives off smoke particles

When water flows into lava, the hissing noise plays, but the accompanying smoke no longer appears. I suspect it's been like this since the Great SMP Switchover.

Not a tremendously huge deal, but does ruin the ability to make smoke machines.

Code analysis: https://bugs.mojang.com/browse/MC-6654?focusedCommentId=284677&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-284677 and https://bugs.mojang.com/browse/MC-10369?focusedCommentId=284639&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-284639

Linked issues

duplicates

MC-10369 Server side particle spawning does not create particles for client

MC-75536 4px skins used on 3px models change texture on bottom of arms

relates to

MC-73857 Redstone torches no longer produce particles when burning out

MC-96974 Armor breaking on monster does not create particles anymore

Comments

Jin-oh Kang 2013-01-09T15:11:42Z

Started from 1.3.1, The minecraft always open a server even if singleplayer, and servers don't support that kinds of particle. So it's NOT a bug.

Taylor Hunt 2013-01-09T23:21:30Z

I agree, it is because of the server swap. However, a lot of other interactions and features that SMP had been missing had been lost in the changeover, and those were restored. I suspect this one should be restored as well, but I can see Team Dinnerjeb deciding it's unnecessary as another valid choice.

Tails 2013-01-11T21:21:39Z

Confirmed in 13w02b.

galaxy_2alex 2014-10-24T22:33:42Z

Is this still a concern in the current Minecraft version 1.8.1 Prerelease 3 / Launcher version 1.5.3 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

marcono1234 2016-02-11T20:06:38Z

Confirmed for

16w06a

marcono1234 2016-02-11T21:40:03Z

Please link to this comment and the comment on MC-10369 in the description of this report

The following is based on decompiled version of Minecraft 1.8 using MCP. All method and class names are the names used in the decompiled version.

How to fix the bug

Instead of having the for loops to create the particles, the following could / should be used:

Affected class: net.minecraft.block.BlockLiquid
Affected method: protected void func_180688_d(World worldIn, BlockPos p_180688_2_)

New code:
p_180688_2_ - The BlockPos of the lava block

((WorldServer) worldIn).func_175739_a(EnumParticleTypes.SMOKE_LARGE, (double)p_180688_2_.getX() + 0.5D, (double)p_180688_2_.getY() + 1.2D, (double)p_180688_2_.getZ() + 0.5D, 8, 0.25D, 0D, 0.25D, 0D, new int[0]);