[MC-112684] Legacy ban entries not correctly converted, end date used as start date as well

The bug

I quickly tested by getting the vanilla server to convert an old banned-players.txt file to the new format because it calls this constructor.

simon8162|2016-01-01 12:00:00 GMT|admin|2018-01-01 12:00:00 GMT|reason

[
    {
        "uuid": "48708698-b1b1-43f2-908d-5383bbaa27bb",
        "name": "simon8162",
        "created": "2018-01-01 12:00:00 +0000",
        "source": "admin",
        "expires": "2018-01-01 12:00:00 +0000",
        "reason": "reason"
    }
]

"created" should be 2016-01-01 12:00:00 +0000 but is instead 2018-01-01 12:00:00 +0000

Code analysis

Source: https://github.com/SpongePowered/SpongeCommon/issues/1129
Faulty constructor: net.minecraft.server.management.UserListBansEntry.UserListBansEntry(GameProfile, Date, String, Date, String)

Comments 1

tryashtar 2020-02-16T03:38:24Z

In 1.15.1 I get this output:

[
  {
    "uuid": "47d14d0d-6d1a-332a-81f4-f1fe8ab22555",
    "name": "simon8162",
    "created": "2016-01-01 05:00:00 -0700",
    "source": "admin",
    "expires": "2018-01-01 05:00:00 -0700",
    "reason": "reason"
  }
]

So I am closing this issue