mojira.dev
MC-113381

Falling dust particles of anvil and concrete powder blocks are black

The bug

Falling dust particles from anvils and concrete powder blocks are always black. See screenshots.

Code analysis

Based on 17w06a decompiled using JD GUI and 1.11.2 decompiled using MCP 9.35 rc1

The concrete powder block does not override the method net.minecraft.block.BlockFalling.getDustColor(IBlockState). Considering that no block is only a BlockFalling but instead as of 1.11.2 every block is a subclass, it might be better if BlockFalling was abstract and the getDustColor method as well.

Linked issues

Attachments

Comments 7

Confirmed, here is a command for testing it :

/particle fallingdust ~ ~ ~ 1 1 1 1 100 normal @p 4348

It doesn't seem to affect other new blocks nor blockcrack/blockdust.

Included anvils as their particle should be gray. Same reason as for concrete powder.

Confirmed for 17w47b

can reproduce in 1.13-pre7

can reproduce in 1.13-pre8

Based on 1.12.2 (with MCP 940, mcp-stable-39 mappings), code, the fix is very easily. In the class `BlockConcretePowder` (which extends BlockFalling`), there is an overridden method missing. Using 1.12 symbols, the method will something like

public class BlockConcretePowder extends BlockFalling {
// ...
    @Override
    public int getDustColor(IBlockState state)
    {
        return state.getValue(COLOR).getColorValue(); }
    }
// ...
}

Hopefully, this (simple) fix will help Mojang.

can reproduce in 1.15.2

tomudding

Felix Jones

Confirmed

Block states, Particles

anvil, concrete_powder, particle

Minecraft 1.11.2, Minecraft 17w06a, Minecraft 17w13a, Minecraft 17w13b, Minecraft 17w14a, ..., 19w42a, 1.15 Pre-release 1, 1.15 Pre-Release 2, 1.15 Pre-release 6, 1.15.2

20w06a

Retrieved