[MC-115149] `source_entity` doesn't function correctly as advancement trigger condition

If I set up an advancement with the following JSON data:

{
    "display": {
        "icon": "minecraft:wool",
        "title": "Arrow damage test"
    },
    "parent": "minecraft:testing/root",
    "criteria": {
        "take_arrow_damage": {
            "trigger": "minecraft:player_damaged",
            "conditions": {
                "damage": {
                    "source_entity": {
                        "type": "arrow"
                    }
                }
            }
        }
    }
}

The advancement doesn't seem to trigger, even after taking arrow damage. Changing this to `skeleton` also seems not to work, which makes me think either I'm missing the point or this might be broken.

Linked issues

duplicates 1

MC-115067 All instances of entity-matching conditions do not function for advancements Resolved

Comments 3

Skylinerw 2017-03-31T14:38:50Z

After checking other instances of "entity" in 17w13b, I've expanded the original MC-115067 to include all instances and am resolving this report to that one.

marcono1234 2017-03-31T16:07:25Z

~~I am pretty sure you are missing the~~ damage type ~~key after the~~ damage ~~key, but even with that it does not work correctly~~

Edit: "damage type" is only the describing name, sorry

Skylinerw 2017-03-31T16:09:22Z

@unknown: his structure was correct. Here is an example of correct structure where the advancement works:

{
    "criteria": {
        "findme": {
            "trigger": "minecraft:player_damaged",
            "conditions": {
                "damage": {
                    "is_fire": false
                }
            }
        }
    }
}

The issue is source_entity specifically, in all cases of its use.