[MC-115067] All instances of entity-matching conditions do not function for advancements

No condition that makes use of an "entity" source functions. This includes:

minecraft:bred_animals trigger.
minecraft:player_damaged trigger.
minecraft:summoned_entity trigger.
minecraft:player_killed_entity trigger.

Given the example advancement, placed in world/data/advancements/custom/cow.json:

{
    "criteria": {
        "findme": {
            "trigger": "minecraft:bred_animals",
            "conditions": {
                "child": {
                    "type":"minecraft:cow"
                }
            }
        }
    }
}

And the following command to test it at will (see MC-115064 for namespace issue):

/advancement test @p minecraft:custom/cow

Breeding two cows to create a calf will not fulfill the condition, showing no errors. The same occurs with the parents array, though they would likely both be fixed at the same time.

Linked issues

is duplicated by 4

MC-114957 summoned_entity advancement trigger doesn't work for villager_golem Resolved

MC-115149 `source_entity` doesn't function correctly as advancement trigger condition Resolved

MC-115298 Very buggy. Resolved

MC-115310 this one is annoying Resolved

Comments 3

Skylinerw 2017-03-31T14:38:12Z

Expanded to include all instances of entity matching.

marcono1234 2017-03-31T16:32:32Z

You were right, if the decompiler decompiled the class ac (17w13a name) correctly the method ac.a is very likely causing that.

public boolean a(@Nullable ub ub2) {
    if (this == a) {
        return this == a;
    }
    if (ub2 == null) {
        return false;
    }
    if (this.b != null && !ud.a(ub2, this.b)) {
        return false;
    }
    return false;
}

It should probably return true in the end since all non-matching tests have failed.

tryashtar 2017-04-03T19:46:13Z

if (this == a) {
        return this == a;
    }

... I feel like that can be improved, haha.