The bug
When you punch the air with an item in the main hand and a cast fishing rod in the off-hand, the main hand (item) makes a punch animation as expected, but the off-hand (item) shouldn't move. As the rod itself remains still as expected, the cast fishing line of the rod in the off-hand moves strangely up and down the length of the rod.
It appears as if the fishing line thinks its rod is being used to punch, but it isn't as it is in the off-hand. The fishing line makes a similar movement to as if the rod were indeed in the punching hand. In the attached image you can see the the fishing line has moved down the rod while my main hand is punching something (and is at this point because of that just outside my view).
How to reproduce:
Put any fishing rod in the off-hand
Right-click to cast the line
Left-click to punch in the air
❌ notice how the off-hand and the rod in it don't animate, but its fishing line does
Code analysis
Code analysis by @unknown can be found in this comment.
Linked issues
is duplicated by 16
MC-117621
Left click when fishing by secondary hand makes the fishing line disconnect to the rod.
Resolved
MC-120953
Fishing rod line BUG
Resolved
MC-124541
offhand fishing rod graphics glitch
Resolved
MC-137363
Fishing rod's animation when in offhand is played on item in main hand
Resolved
MC-169988
fishing rod
Resolved
MC-192739
Fishing Line using animation in off hand
Resolved
MC-195531
fisning rod bug
Resolved
MC-197439
Fishing rod appears briefly reeled in when in offhand and throwing splash potions
Resolved
MC-208080
Fishing rod line behaves incorrectly once dual wielded
Resolved
MC-209063
The behavior of the fishing rod thread is strange
Resolved
MC-221924
Fishing Rod Bug [UPDATED]
Resolved
MC-223087
Fishing line doesn't show correctly while using rod in left hand
Resolved
MC-238169
Fishing rod animation working wrong
Resolved
MC-260017
Fishing rod string - visual Bug.
Resolved
MC-273650
Lines of off-hand fishing rods stretch when they shouldn't
Resolved
MC-295650
Fishing rod line plays animations with main-hand item when fishing rod is in offhand
Resolved
Attachments
Comments
JUE13
Jack McKalling
Replaced screenshot with new one without resource pack, my apologies. Screenshot taken in 1.12.2.
Jack McKalling
Still present in 1.13.2
Hayden Wong
Confirmed for 19w08a and 19w08b.
In 1.16 Release Candidate-1 It now moves up no matter which hand is it in.
Avoma
Can confirm in 21w03a.
Chandler
At net.minecraft.client.render.entity.FishingBobberEntityRenderer.render() (Based on 21w05b yarn mappings) The fishing bobber gets the hand that is currently holding a fishing rod in it. It then uses the main hand's swing progress to determine the fishing line's animation when punching, which is currently used as part of the animation regardless of which hand is holding the fishing rod.
int j = lv.getMainArm() == Arm.RIGHT ? 1 : -1;
ItemStack lv6 = lv.getMainHandStack();
if (!lv6.isOf(Items.FISHING_ROD)) {
j = -j;
}
float h = lv.getHandSwingProgress(g);
float k = MathHelper.sin(MathHelper.sqrt(h) * (float)Math.PI);This could be fixed by checking if the hand with the fishing rod is the same as the main hand, and if not then setting h to 0:
int j = lv.getMainArm() == Arm.RIGHT ? 1 : -1;
int j2 = j;
ItemStack lv6 = lv.getMainHandStack();
if (!lv6.isOf(Items.FISHING_ROD)) {
j = -j;
}
float h = j == j2 ? lv.getHandSwingProgress(g) : 0;
float k = MathHelper.sin(MathHelper.sqrt(h) * (float)Math.PI);Blocked from testing in 21w11a, by MC-219849
MMK21
Affects 1.18. Right-clicks that cause a hand action are also effected.
MMK21
Affects 1.18.1
Avoma
Can confirm in 1.18.2.
Avoma
Can confirm in 1.19.
Avoma
Can confirm in 1.19.2.
Confirmde for 17w17a