mojira.dev
MC-118737

Resource packs do not load any files from the text folder under another namespace

The bug

When you make a resource pack that uses another folder in assets other than minecraft (the namespace folder) everything gets loaded and shown but credits, end_poem and splashes (models, textures, sounds, sounds.json and lang files load and show fine).

How to reproduce

  • Create a resource pack with the following files:

    asstes/minecraft/texts/splashes.txt
    assets/minecraft/texts/end_poem.txt
    assets/minecraft/texts/postcredits.txt
    assets/minecraft/texts/credits.json
    asstes/test/texts/splashes.txt
    assets/test/texts/end_poem.txt
    assets/test/texts/postcredits.txt
    assets/test/texts/credits.json

    containing the following text (for txt files):

    • minecraft: Test1

    • test: Test2
      And the following text for credits.json:

    • minecraft:

      [
          {
              "section": "MC-118737",
              "titles": [
                  {
                      "title": "Test title 1",
                      "names": [
                          "Test1"
                      ]
                  }
              ]
          }
      ]
    • test:

      [
          {
              "section": "MC-118737",
              "titles": [
                  {
                      "title": "Test title 2",
                      "names": [
                          "Test2"
                      ]
                  }
              ]
          }
      ]
  • Load the resource pack and go into a world

  • Go in and out of the end

  • Observe 3 times Test1 but never Test2

  • Observe the Test1 splash

  • Reopen and leave a world a couple of times

  • Test2 never gets shown as a splash

Potential fix:

  • splashes: in the list of randomly chosen splashes, do not overwrite the list, but add to the list if it's not from the same namespace

  • credits/poem: when it gets shown, show them on alphabetical order of namespace (test comes after minecraft, but a_test comes before it), first show all the poems and then all the credits.

Attachments

Comments 7

Is this still a issue in the latest version of the game(currently 1.13.1)?

If so, please add it to the affected versions, thanks!

Affects 1.16 Release Candidate 1
Attached resourcepack. Made changes. end_poem.txt is end.txt in 1.16

Affects 1.17 Pre-release 4

user-f2760

(Unassigned)

Community Consensus

(Unassigned)

credits, end_poem, resource-pack, splashes

Minecraft 1.12, Minecraft 1.12.1 Pre-Release 1, Minecraft 1.12.2, Minecraft 18w02a, Minecraft 18w19b, ..., 1.19.3, 1.19.4, 1.20.1, 1.20.2, 23w43b

Retrieved