[MC-123708] clearCustomName() and hasDisplayName() inconsistent

The bug

The clearCustomName() and hasDisplayName() methods in the ItemStack class are inconsistent with getDisplayName() as they ignore the LocName NBT Tag used for custom translated displaynames.

Linked issues

relates to 2

MC-123804 Explorer map and Ominous banner names appear in item frames, draw in italics, and can be removed with an anvil Resolved

MC-123790 "italic":false in custom item names does not make name non-italic Resolved

Comments 2

pokechu22 2017-12-31T18:44:14Z

hasDisplayName() only checking Name is what makes LocName-named items not render in italic (which is needed for e.g. villager treasure maps). I'm pretty sure that, as such, this is intended.

tryashtar 2017-12-31T19:38:58Z

Also just because the MCP mappers named them in a way that would indicate they're related doesn't mean Mojang did.