[MC-12699] Some PNGs using greyscale or tRNS are processed incorrectly

Minecraft does not process some PNGs correctly. Specifically, it does not seem to implement the tRNS specification fully, nor does it handle greyscale PNGs correctly. Attached are some vanilla textures from the most recent snapshot as of this writing (15w42a) that render incorrectly when compressed with ScriptPNG's most aggressive lossless setting. (If Mojang did this compression themselves, Minecraft's PNGs would be 34.45% [1299 KB] smaller, which is a not-insignificant amount of bandwidth.)

Linked issues

duplicates 1

MC-12949 Minecraft ran out of memory: java.lang.OutOfMemoryError Resolved

Attachments

textures_compressed_15w42a.zip

Comments 15

GFD 2013-03-23T18:25:50Z

Interestingly, Irfanview and XnView also render these compressed PNGs in exactly the same way Minecraft does. Other applications, including Windows Photo Viewer, Google Chrome, or GIMP, will render them correctly. Does Minecraft share a library with XnView and Irfanview for rendering PNGs?

insomniac_lemon 2013-03-24T04:21:44Z

Wow.... didn't think somebody would report this, let alone yesterday! Saves me the trouble, though.

I am a texture pack creator, and just got the idea to use an image compression tool, I found one for Ubuntu called "trimage" (Trim-age, like mixing trim and image. It uses optipng, advpng, and pngcrush), it cuts the size of my texture pack in half!

However, much like you, I noticed that images that were grayscaled displayed in Minecraft too bright and with transparency displayed as black. However, in GIMP, Chrome, EOG (Eye Of GNOME, the GNOME image viewer), and Nautilus thumbnails all display these images properly.

It would be nice to see this bug fixed, as it's an annoyance to actually find out which images are grayscaled (for some reason trimage seems to keep some of them indexed....) and then you gain a slightly larger file size (for me it added 1 KiB) which probably in larger texture packs (both in data and resolution) would add up much more than my texture pack.

Mojang should also fix this to encourage .PNG optimization a little more (or really, just not accidentally discourage it....)

GFD 2013-05-22T20:31:42Z

Yes, this is still an issue in 13w19a.

GFD 2013-05-23T18:59:34Z

Added a new .zip with 13w21a's textures compressed with pngslim 1.4.

GFD 2013-06-26T17:59:35Z

This is still an issue with the new resource pack format. Added a new .zip with 1.6's textures compressed with pngslim 1.4.

5 more comments

insomniac_lemon 2013-10-30T11:11:03Z

Arg, can't believe this small issue still isn't fixed.

I think the issue is not with the libraries that render textures, but the libraries that process textures in order to stitch them! I think that this library is reading grayscale .PNGs wrong, and then writing them to the atlas wrong as a result. If the that library cannot be changed, possibly there could be a check for grayscale textures before that library, and if so, convert the mode to RGB before attempting to read it?

I know this getting fixed would solve me a great deal of needed precautions and potential issues.... such as not needing to refrain from using an image optimizer on images that are all gray, or needing to re-edit them to switch from grayscale to indexed.

Carter Merrill 2013-11-03T09:59:18Z

I also have this issue. It's a pain to run a batch optimizer on a texture pack and load it up to find out that some textures are rendered incorrectly and having to manually go back and change them to RGB.

Andrew Harrison 2014-03-25T23:38:53Z

I came across the same problem, and I have fixed it in my client today. The bug is in Java's ImageIO thingy. I replaced the calls to ImageIO.read with javapng (http://code.google.com/p/javapng/), and grayscale images render properly now. This is a very simple change and it shouldn't take much time for Mojang to implement.

Deleted account 2014-05-25T07:37:50Z

Is this still a concern in the current Minecraft version 14w21b / Launcher version 1.4.4 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

GFD 2014-07-16T18:18:13Z

Yes, this is still bugged.

insomniac_lemon 2015-03-11T00:31:14Z

Still an issue in 1.8.3.

[Mod] redstonehelper 2015-10-15T18:32:09Z

Since you attached textures_compressed_15w42a.zip, does this also affect 15w42a?

GFD 2015-10-15T23:19:11Z

Yep, added.

Erik Broes 2015-11-30T05:19:15Z

Java itself handles our png files. Seems I might end up writing our own loader code for this. Definitely not happening before 1.10.

tryashtar 2018-01-29T17:53:41Z

Not noticing any issues when trying that resource pack in 18w03b. This was probably fixed even earlier.

As for the "should" of this report (the game's image files should be compressed further), I'll not comment.